Update component code coverage and dependencies docs #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrski
added a commit
that referenced
this pull request
Dec 2, 2022
* Rename method for semantic clarity This method returns a completely new, fresh connection every time, whereas 'get' implies potential reuse of an existing object. * Add authority param to scheduler client constructor + update callers * Reorganise gRPC connection method into per-dial option sections * Create list of dial opts atomically instead of appending in gRPC connection setup This makes it easier to see which dial options are being set, especially with more complex logic or if we add chained interceptors. * Split flag/env var/default constants into separate blocks for clarity * Fix typo in name of default var * Add authority option to gRPC connection creation in scheduler client * Make CLI cmd package-only constants private instead of public * Rename CLI flag vars to use 'flag' as the prefix This aids discoverability, implies logical grouping of all flag variables (this is harder to determine with suffixes), and is consistent with the env vars and defaults. * Order blocks of CLI flags/env vars/defaults alphabetically * Use constant for scheduler-host help statement in CLI commands Rather than replicating the same string in about 15 different places and risking typos or inconsistencies, we can use a single constant. * Add constants for shared flag help docs for CLI subcommands * Reword some command flag help docs for clarity * Add authority flag to CLI subcommands communicating with the scheduler * Reorder statements & add blank lines for logical grouping * Add authority flag for model metadata subcommand & use in REST call to server * Reorder lines for legibility * Update help message for header flag * Order help messages alphabetically * Fix typo in var name * Rename flag var for consistency * Move sticky session flag to flags file as shared between subcommands * Rename more flag vars for consistency of format, i.e. flagX not xFlag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.