Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permission and timeout changes after trying on an openshift4 cluster #524

Merged
merged 2 commits into from
Apr 24, 2019
Merged

permission and timeout changes after trying on an openshift4 cluster #524

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c45fccc
permission and timeout changes after trying on an openshift4 cluster
ryandawsonuk Apr 24, 2019
7e724e6
pod is alive if it responds
ryandawsonuk Apr 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cluster-manager/src/main/java/io/seldon/clustermanager/k8s/SeldonDeploymentOperatorImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,10 +139,10 @@ private V1.Container createEngineContainer(SeldonDeployment mlDep,PredictorSpec
.setTimeoutSeconds(2)
)
.setLivenessProbe(Probe.newBuilder().setHandler(Handler.newBuilder()
.setHttpGet(HTTPGetAction.newBuilder().setPort(IntOrString.newBuilder().setType(1).setStrVal("admin")).setPath("/ready")))
.setHttpGet(HTTPGetAction.newBuilder().setPort(IntOrString.newBuilder().setType(1).setStrVal("admin")).setPath("/live")))
.setInitialDelaySeconds(20)
.setPeriodSeconds(5)
.setFailureThreshold(3)
.setFailureThreshold(7)
.setSuccessThreshold(1)
.setTimeoutSeconds(2)
)
Expand Down
17 changes: 15 additions & 2 deletions engine/src/main/java/io/seldon/engine/api/rest/RestClientController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public class RestClientController {

@PostConstruct
public void init(){
ready.set(true);;
ready.set(true);
}

@RequestMapping("/")
Expand Down Expand Up @@ -95,7 +95,20 @@ ResponseEntity<String> ready() {
ResponseEntity<String> responseEntity = new ResponseEntity<String>(ret, responseHeaders, httpStatus);
return responseEntity;
}


@RequestMapping("/live")
ResponseEntity<String> live() {

HttpHeaders responseHeaders = new HttpHeaders();
HttpStatus httpStatus;
String ret = "live";
httpStatus = HttpStatus.OK;

ResponseEntity<String> responseEntity = new ResponseEntity<String>(ret, responseHeaders, httpStatus);
return responseEntity;
}


@RequestMapping("/pause")
String pause() {
ready.set(false);
Expand Down
5 changes: 5 additions & 0 deletions helm-charts/seldon-core/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,9 @@ redis:
usePassword: false
cluster:
enabled: false
securityContext:
enabled: false
master:
securityContext:
enabled: false
single_namespace: true