Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): V2D-1268 Use smaller model in SCv1 demo but still reference larger one #5119

Conversation

vtaskow
Copy link
Contributor

@vtaskow vtaskow commented Sep 1, 2023

What this PR does / why we need it:
Replacing the massive GPT2 model with a smaller one - tiny stories. The smaller one will be used in Cypress tests. The larger one will still be referenced in case clients would like to run more realistic models. The intention is to tie the Cypress tests together with the Demo pages by using the same GCS models. Tracking future problems will be easier and more visible in case something breaks.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment on lines +97 to +99
````{note}
As a next step, why not try running a larger-scale model? You can find one in gs://seldon-models/v1.18.0-dev/huggingface/text-gen-custom-gpt2. However, you may need to request more memory!
````
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch!

@vtaskow vtaskow merged commit 24dd8a7 into SeldonIO:master Sep 1, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants