Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.6 s2i wrapper #5007

Merged
merged 2 commits into from
Jul 10, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions doc/source/python/python_wrapping_s2i.md
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,6 @@ See below for the possible keys and values for this file.
## Step 3 - Build your image
Use `s2i build` to create your Docker image from source code. You will need Docker installed on the machine and optionally git if your source code is in a public git repo. You can choose from three python builder images

* Python 3.6 : seldonio/seldon-core-s2i-python36:1.17.0-dev seldonio/seldon-core-s2i-python3:1.17.0-dev
* Note there are [issues running TensorFlow under Python 3.7](https://github.com/tensorflow/tensorflow/issues/20444) (Nov 2018) and Python 3.7 is not officially supported by TensorFlow (Dec 2018).
* Python 3.6 plus ONNX support via [Intel nGraph](https://github.com/NervanaSystems/ngraph) : seldonio/seldon-core-s2i-python3-ngraph-onnx:0.1

Using s2i you can build directly from a git repo or from a local source folder. See the [s2i docs](https://github.com/openshift/source-to-image/blob/master/docs/cli.md#s2i-build) for further details. The general format is:

```bash
Expand Down
2 changes: 0 additions & 2 deletions doc/source/reference/images.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,8 @@
| Description | Image URL | Stable Version | Development |
|-------------|-----------|----------------|-------------|
| [Seldon Python 3 (3.8) Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python3](https://hub.docker.com/r/seldonio/seldon-core-s2i-python3/tags/) | 1.16.0 | 1.17.0-dev |
| [Seldon Python 3.6 Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python36](https://hub.docker.com/r/seldonio/seldon-core-s2i-python36/tags/) | 1.16.0 | 1.17.0-dev |
| [Seldon Python 3.7 Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python37](https://hub.docker.com/r/seldonio/seldon-core-s2i-python37/tags/) | 1.16.0 | 1.17.0-dev |
| [Seldon Python 3.8 Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python38](https://hub.docker.com/r/seldonio/seldon-core-s2i-python38/tags/) | 1.16.0 | 1.17.0-dev |
| [Seldon Python 3.6 GPU Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python36-gpu](https://hub.docker.com/r/seldonio/seldon-core-s2i-python36-gpu/tags/) | 1.16.0 | 1.17.0-dev |
| [Seldon Python 3.7 GPU Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python37-gpu](https://hub.docker.com/r/seldonio/seldon-core-s2i-python37-gpu/tags/) | 1.16.0 | 1.17.0-dev |
| [Seldon Python 3.8 GPU Wrapper for S2I](../python/python_wrapping_s2i.md) | [seldonio/seldon-core-s2i-python38-gpu](https://hub.docker.com/r/seldonio/seldon-core-s2i-python38-gpu/tags/) | 1.16.0 | 1.17.0-dev |

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@
],
"source": [
"%%bash\n",
"SELDON_BASE_WRAPPER=\"seldonio/seldon-core-s2i-python36:1.17.0-dev
"SELDON_BASE_WRAPPER=\"seldonio/seldon-core-s2i-python37:1.17.0-dev
"s2i build src/. $SELDON_BASE_WRAPPER sklearn-server:0.1 \\\n",
" --environment-file src/seldon_model.conf"
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@
],
"source": [
"%%bash\n",
"SELDON_BASE_WRAPPER=\"seldonio/seldon-core-s2i-python36:1.17.0-dev
"SELDON_BASE_WRAPPER=\"seldonio/seldon-core-s2i-python37:1.17.0-dev
"s2i build src/. $SELDON_BASE_WRAPPER sklearn-server:0.1 \\\n",
" --environment-file src/seldon_model.conf"
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@
],
"source": [
"%%bash\n",
"SELDON_BASE_WRAPPER=\"seldonio/seldon-core-s2i-python36:1.17.0-dev
"SELDON_BASE_WRAPPER=\"seldonio/seldon-core-s2i-python37:1.17.0-dev
"s2i build src/. $SELDON_BASE_WRAPPER sklearn-server:0.1 \\\n",
" --environment-file src/seldon_model.conf"
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ IMAGE_VERSION=0.3
IMAGE_NAME=docker.io/seldonio/imagenet-transformer

build:
s2i build -E environment . seldonio/seldon-core-s2i-python36:1.17.0-dev $(IMAGE_NAME):$(IMAGE_VERSION)
s2i build -E environment . seldonio/seldon-core-s2i-python37:1.17.0-dev $(IMAGE_NAME):$(IMAGE_VERSION)

push_to_dockerhub:
docker push $(IMAGE_NAME):$(IMAGE_VERSION)
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@
}
],
"source": [
"!s2i build . seldonio/seldon-core-s2i-python36:1.17.0-dev deep-mnist:0.1"
"!s2i build . seldonio/seldon-core-s2i-python37:1.17.0-dev deep-mnist:0.1"
]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,7 @@
}
],
"source": [
"!s2i build . seldonio/seldon-core-s2i-python36:1.17.0-dev deep-mnist:0.1"
"!s2i build . seldonio/seldon-core-s2i-python37:1.17.0-dev deep-mnist:0.1"
]
},
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@
}
],
"source": [
"!s2i build . seldonio/seldon-core-s2i-python36:1.17.0-dev deep-mnist:0.1"
"!s2i build . seldonio/seldon-core-s2i-python37:1.17.0-dev deep-mnist:0.1"
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion examples/models/resnet/Makefile
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@


build_image:
s2i build -E environment_grpc . seldonio/seldon-core-s2i-python36:1.17.0-dev seldon-resnet2.4
s2i build -E environment_grpc . seldonio/seldon-core-s2i-python37:1.17.0-dev seldon-resnet2.4


clean:
Expand Down
2 changes: 1 addition & 1 deletion examples/models/resnet/reset.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@
}
],
"source": [
"!s2i build -E environment_grpc . seldonio/seldon-core-s2i-python36:1.17.0-dev seldon-resnet2.4"
"!s2i build -E environment_grpc . seldonio/seldon-core-s2i-python37:1.17.0-dev seldon-resnet2.4"
]
},
{
Expand Down
1 change: 0 additions & 1 deletion wrappers/s2i/python/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ clean:
rm -rf test/transformer-template-app/.git

after_build_image_seldon_core_check:
docker run --rm -it docker.io/seldonio/seldon-core-s2i-python36:$(IMAGE_VERSION) python -c 'import seldon_core; print(seldon_core.version.__version__)'
docker run --rm -it docker.io/seldonio/seldon-core-s2i-python37:$(IMAGE_VERSION) python -c 'import seldon_core; print(seldon_core.version.__version__)'


Expand Down
7 changes: 3 additions & 4 deletions wrappers/s2i/python/build_scripts/build_all.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@
make -C ../ build_conda_base

# Build standard wrapper images
make -C ../ build PYTHON_VERSION=3.6
make -C ../ build PYTHON_VERSION=3.7.10
# NOTE: Conda 23.1.0 is the last version to support Python 3.7
make -C ../ build PYTHON_VERSION=3.7.10 CONDA_VERSION=23.1.0
make -C ../ build PYTHON_VERSION=3.8.10

# Tag the default image
make -C ../ tag_base_python PYTHON_VERSION=3.8.10

# Build GPU images
make -C ../ build_gpu PYTHON_VERSION=3.6
make -C ../ build_gpu PYTHON_VERSION=3.7.10
make -C ../ build_gpu PYTHON_VERSION=3.7.10 CONDA_VERSION=23.1.0
make -C ../ build_gpu PYTHON_VERSION=3.8.10
Loading