Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Alibi and Alibi-Detect versions and bump servers to Python 3.8 #4912

Merged
merged 16 commits into from
Jun 28, 2023
Merged

Update Alibi and Alibi-Detect versions and bump servers to Python 3.8 #4912

merged 16 commits into from
Jun 28, 2023

Conversation

adriangonz
Copy link
Contributor

What this PR does / why we need it:

  • Bump Python to 3.8 on Alibi Explain and Detect servers by using base Conda version (which also happens to be 3.8)
  • Remove flatbuffers from seldon-core package (which doesn't seem to be used?)
  • Update Conda to latest version in base seldonio/conda-ubi8 image
  • Bump Alibi Detect and Explain to latest

Which issue(s) this PR fixes:

Part of #4803

Special notes for your reviewer:

@adriangonz adriangonz requested review from RafalSkolasinski and ukclivecox and removed request for RafalSkolasinski June 12, 2023 16:55
@adriangonz
Copy link
Contributor Author

/test integration

@adriangonz adriangonz mentioned this pull request Jun 12, 2023
Merged
@adriangonz
Copy link
Contributor Author

/test integration

@adriangonz
Copy link
Contributor Author

/test notebooks

@adriangonz
Copy link
Contributor Author

/test integration

@adriangonz
Copy link
Contributor Author

/test notebooks

@adriangonz
Copy link
Contributor Author

/test integration

@ukclivecox ukclivecox added the v1 label Jun 17, 2023
@adriangonz
Copy link
Contributor Author

/retest

@adriangonz
Copy link
Contributor Author

/test integration

@adriangonz
Copy link
Contributor Author

/test notebooks

@adriangonz
Copy link
Contributor Author

/test integration

@adriangonz
Copy link
Contributor Author

/test notebooks

@adriangonz
Copy link
Contributor Author

/test integration

1 similar comment
@adriangonz
Copy link
Contributor Author

/test integration

@adriangonz
Copy link
Contributor Author

/test notebooks

@adriangonz
Copy link
Contributor Author

Both notebook and integration tests passing:

image

@adriangonz adriangonz merged commit 022336c into SeldonIO:master Jun 28, 2023
@adriangonz adriangonz deleted the bump-python-alibi branch June 28, 2023 12:13
@adriangonz adriangonz mentioned this pull request Jul 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukclivecox ukclivecox Awaiting requested review from ukclivecox

@RafalSkolasinski RafalSkolasinski Awaiting requested review from RafalSkolasinski

Assignees
No one assigned
Labels
v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriangonz @ukclivecox