Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing resttemplate setter from predictionService #393

Merged
merged 4 commits into from
Jan 18, 2019
Merged

removing resttemplate setter from predictionService #393

merged 4 commits into from
Jan 18, 2019

Conversation

ro7m
Copy link
Contributor

@ro7m ro7m commented Jan 16, 2019

removing resttemplate setter from predictionService and related tests.
@cliveseldon please review.

@ukclivecox ukclivecox self-requested a review January 16, 2019 17:21
ukclivecox
ukclivecox approved these changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@ukclivecox ukclivecox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. This is a great addition to removing that and improving the testing.

@ukclivecox ukclivecox merged commit e45fc09 into SeldonIO:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ukclivecox ukclivecox ukclivecox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ro7m @ukclivecox