Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow further options for binary and tensors in prediction API #321

Merged
merged 12 commits into from
Dec 3, 2018
Merged

Allow further options for binary and tensors in prediction API #321

merged 12 commits into from
Dec 3, 2018

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented Dec 2, 2018 •
edited
Loading

Adds two updates for prediction API:

  1. The present proto buffer definitions allow custom binary or string payloads to be sent but these are presently ignored by the python wrappers.
  2. Adds Tensorflow TensorProto to prediction API to allow the flexibility and extra efficiency in data types to be used in prediction API.

Fixes #225

@ukclivecox ukclivecox changed the title Allow binary and string data payload entries to be used in python wrapper Allow further options for binary and tensors in prediction API Dec 2, 2018
@ukclivecox ukclivecox requested a review from jklaise December 2, 2018 20:44
@ukclivecox ukclivecox merged commit 0c4b6ac into SeldonIO:master Dec 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklaise jklaise Awaiting requested review from jklaise

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

strData & binData not accepted by Python model microservice
2 participants
@ukclivecox @jklaise