Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix crd.libsonnet error #177

Merged
merged 1 commit into from
Jun 28, 2018
Merged

fix crd.libsonnet error #177

merged 1 commit into from
Jun 28, 2018

Conversation

nicholas-fwang
Copy link
Contributor

Error when apply crd.libonnet of seldon-core through ksonnet

ks registry add seldon-core github.com/SeldonIO/seldon-core/tree/master/seldon-core && \
ks pkg install seldon-core/seldon-core@master && \
ks generate seldon-core seldon-core --withApife=false --namespace=seldon --withRbac=true
ks apply default

ERROR find objects:
vendor/seldon-core/seldon-core/crd.libsonnet:258:2-3 Did not expect: (",", ",")
},

@ukclivecox
Copy link
Contributor

Which version of ksonnet are you using? Maybe this is a change in a newer version that does not allow this?

@nicholas-fwang
Copy link
Contributor Author

I'm using v0.11.0 and currently latest version.

$ ks version
ksonnet version: 0.11.0
jsonnet version: v0.10.0

@ukclivecox
Copy link
Contributor

Thanks for the fix!

@ukclivecox ukclivecox merged commit a0997db into SeldonIO:master Jun 28, 2018
agrski pushed a commit that referenced this pull request Dec 2, 2022
@ukclivecox
fix docker compose for host network (#177)
4d6ab1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicholas-fwang @ukclivecox