Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo fix: missing api in io.seldon.wrapper.api.SeldonPredictionService #1332

Merged
merged 1 commit into from
Jan 13, 2020
Merged

typo fix: missing api in io.seldon.wrapper.api.SeldonPredictionService #1332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions doc/source/java/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ To use our s2i builder image to package your Java model you will need:

* A Maven project that depends on ```io.seldon.wrapper``` library
* A Spring Boot configuration class
* A class that implements ```io.seldon.wrapper.SeldonPredictionService``` for the type of component you are creating
* A class that implements ```io.seldon.wrapper.api.SeldonPredictionService``` for the type of component you are creating
* .s2i/environment - model definitions used by the s2i builder to correctly wrap your model

We will go into detail for each of these steps:
Expand Down Expand Up @@ -65,7 +65,7 @@ public class App {
```

### Prediction Class
To handle requests to your model or other component you need to implement one or more of the methods in ```io.seldon.wrapper.SeldonPredictionService```, in particular:
To handle requests to your model or other component you need to implement one or more of the methods in ```io.seldon.wrapper.api.SeldonPredictionService```, in particular:

```java
default public SeldonMessage predict(SeldonMessage request);
Expand Down Expand Up @@ -208,9 +208,3 @@ The service type being created. Available options are:

* [A minimal skeleton for model source code](https://github.com/seldonio/seldon-core/tree/incubating/wrappers/s2i/java/test/model-template-app)
* [Example H2O MOJO](../examples/h2o_mojo.html)