Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set deployment replicas #1316

Merged
merged 1 commit into from
Jan 8, 2020

Conversation

andrewshaoyu
Copy link
Contributor

set deployment replicas when operator reconcile, if replica have been defined in crd that will be used,otherwise use the found replicas which is controlled by hpa

@seldondev
Copy link
Collaborator

Hi @andrewshaoyu. Thanks for your PR.

I'm waiting for a SeldonIO or seldonio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ukclivecox
Copy link
Contributor

/ok-to-test

@ukclivecox
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Tue Jan 7 08:23:15 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1316/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1316 --build=1

@seldondev
Copy link
Collaborator

Tue Jan 7 08:23:19 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1316/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1316 --build=2

@seldondev
Copy link
Collaborator

Tue Jan 7 08:23:27 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1316/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1316 --build=3

@ukclivecox
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Tue Jan 7 12:03:25 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1316/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1316 --build=4

@ukclivecox
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Wed Jan 8 09:47:39 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1316/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1316 --build=5

@ukclivecox
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor

/test integration

@seldondev
Copy link
Collaborator

Wed Jan 8 13:37:57 UTC 2020
The logs for [integration] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1316/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1316 --build=6

@seldondev
Copy link
Collaborator

@andrewshaoyu: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration a834ab3 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ryandawsonuk
Copy link
Contributor

I tested this locally on Kind as we've been having some issues with the hosted E2E tests. Everything passed locally except a known intermittent 503 issue.

@ryandawsonuk ryandawsonuk merged commit 7a539b6 into SeldonIO:master Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants