Functionality for model wrapper to return JSON on any Dict return #1174
Conversation
…edict method returns Dict
|
It seems the path for the tests is already covered by |
|
/cc @adriangonz @cliveseldon |
axsaucedo
changed the title
|
/test integration |
1 similar comment
|
/test integration |
|
It's a bit scary that we haven't broken any tests after the change. Perhaps it would be good to add one for the new behaviour @axsaucedo? |
|
@adriangonz all the current tests (and expected workflows) for jsonData actually do cover this, as it expects that any inputs of jsonData return a dictionary and hence a jsonData, however now the logic is not based on the input being jsonData, but on the return value being a Dict. This would still cover it, but for the sake of explicitness I'll add another tests that sends a numpy array as input and returns a dict, which would explicitly test that no matter what the input, as long as the output is a dict, it will return jsonData. |
… even if a datadef is provided as input
|
@axsaucedo: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@adriangonz I added now 👍 |
|
/approve Nice! Looks great! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriangonz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1145