Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ojalgo from 47.3.1 to 48.0.0 in /engine #1133

Merged
merged 2 commits into from
Nov 26, 2019
Merged

Bump ojalgo from 47.3.1 to 48.0.0 in /engine #1133

merged 2 commits into from
Nov 26, 2019

Conversation

dependabot-preview[bot]
Copy link
Contributor

Bumps ojalgo from 47.3.1 to 48.0.0.

Changelog

Sourced from ojalgo's changelog.

[48.0.0] – 2019-11-24

Added

  • Improved support for float throughout the library, and specifically added matrices with float elements.

org.ojalgo.algebra

  • ScalarOperation has been extended with support for float arguments.

org.ojalgo.function

  • New special functions: beta (complete, incomplete and regularized), gamma (logarithmic), Hypergeometric and Pochhammer symbol. Inluding complex valued variants where applicable. The complete gamma function existed previously, and the upper/lower incomplete gamma functions are only implemented for the integer case.
  • All the function interaces now have float specific methods.

org.ojalgo.matrix

  • There is a new float based matrix store implementation, Primitive32Store.

org.ojalgo.random

  • The getDistribution() method in the TDistribution is now implemented for the general case. Previously it was only implemented for a few distinct degrees of freedom.

Changed

  • Generic declarations in interfaces and abstract classes (everywhere) that used to be <N extends Number> are now <N extends Comparable<N>>. Code that extends/implements ojAlgo classes and interaces will most likely need to be updated. Simple usage may not require any changes at all. Please note that java.lang.Number is NOT Comparable but all the speciic subclasses are.
  • Everything (classes/interfaces, constants...) named "Primitive" -something now separates between "Primitive32" and "Primitive64".

org.ojalgo.matrix

  • PrimitiveDenseStore has been renamed Primitive64Store (and there is now also a Primitive32Store). GenericDenseStore was also renamed GenericStore. Likewise PrimitiveMatrix is repalced by Primitive64Matrix and Primitive32Matrix.

org.ojalgo.scalar

  • ComplexNumber and Quaternion are now final. That means there are no longer special normalised subclasses (no Versor).

org.ojalgo.structure

  • The methods in the Mutate*D.Fillable interaces that take a NullaryFunction as input has changed the generic declaration from NullaryFunction<N> to NullaryFunction<?>.
  • Reftactoring of the Factory*D interfaces.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

  • Update frequency
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview
Bump ojalgo from 47.3.1 to 48.0.0 in /engine
c254e9b 
Bumps [ojalgo](https://github.com/optimatika/ojAlgo) from 47.3.1 to 48.0.0.
- [Release notes](https://github.com/optimatika/ojAlgo/releases)
- [Changelog](https://github.com/optimatika/ojAlgo/blob/develop/CHANGELOG.md)
- [Commits](optimatika/ojAlgo@v47.3.1...v48)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file Java labels Nov 25, 2019
@seldondev
Copy link
Collaborator

Hi @dependabot-preview[bot]. Thanks for your PR.

I'm waiting for a SeldonIO or seldonio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@apete
Copy link
Contributor

apete commented Nov 25, 2019

org.ojalgo.matrix.PrimitiveMatrix needs to be replaced by org.ojalgo.matrix.Primitive64Matrix (there is now also a Primitive32Matrix).

@axsaucedo
Copy link
Contributor

@apete thank you very much for the heads up! Are there any breaking changes on this besides that? We'll add your suggestion as well!
/cc @adriangonz

@seldondev seldondev requested a review from adriangonz November 25, 2019 11:27
@axsaucedo
Copy link
Contributor

/ok-to-test
/test integration

@apete
Copy link
Contributor

apete commented Nov 25, 2019

Just looked briefly at your code. I believe you only need to replace PrimitiveMatrix with Primitive64Matrix.

@seldondev seldondev added size/M and removed size/XS labels Nov 25, 2019
@adriangonz
Copy link
Contributor

/test integration

Awesome! It seems to work now. Thanks @apete !

@adriangonz
Copy link
Contributor

/test integration

1 similar comment
@adriangonz
Copy link
Contributor

/test integration

@adriangonz
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 627b6bd into master Nov 26, 2019
@dependabot-preview dependabot-preview bot deleted the dependabot/maven/engine/org.ojalgo-ojalgo-48.0.0 branch November 26, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriangonz adriangonz Awaiting requested review from adriangonz

Assignees
No one assigned
Labels
approved dependencies Pull requests that update a dependency file Java ok-to-test size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seldondev @apete @axsaucedo @adriangonz