Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tox #1043

Merged
merged 7 commits into from
Nov 11, 2019
Merged

Add tox #1043

merged 7 commits into from
Nov 11, 2019

Conversation

adriangonz
Copy link
Contributor

Resolves #1042. However, before making any changes we should discuss on #1042 if we want to introduce tox or not.

Changelog

  • Add requirements-dev.txt with pytest, tox and mypy
  • Add tox config to setup.cfg
  • Remove all install-* targets in Makefile and the different steps in jenkins-x.yaml since the diff environments are now hanled by tox

@axsaucedo
Copy link
Contributor

axsaucedo commented Nov 5, 2019

Very cool! It would be worth adding something in the docs to explain this, but other than that looks awesome, and very clean! Maybe just a brief on CONTRIBUTING.md?

@ukclivecox
Copy link
Contributor

Looks good,

@ukclivecox
Copy link
Contributor

/lgtm

@ukclivecox
Copy link
Contributor

/hold

@axsaucedo
Copy link
Contributor

@adriangonz I think after we add version limits + some details in contributing it should be good to go
/approved cancel
/lgtm cancel

@seldondev seldondev added size/L and removed size/M labels Nov 11, 2019
@adriangonz
Copy link
Contributor Author

I've just added some docs and ceilings for the versions in requirements-dev.txt @axsaucedo 👍

@axsaucedo
Copy link
Contributor

Solid! Nice on @adriangonz
/hold cancel
/lgtm
/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo, cliveseldon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [axsaucedo,cliveseldon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit c2ed82f into SeldonIO:master Nov 11, 2019
@axsaucedo axsaucedo removed their assignment May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tox
4 participants