-
Notifications
You must be signed in to change notification settings - Fork 834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tox #1043
Add tox #1043
Conversation
Very cool! It would be worth adding something in the docs to explain this, but other than that looks awesome, and very clean! Maybe just a brief on CONTRIBUTING.md? |
Looks good, |
/lgtm |
/hold |
@adriangonz I think after we add version limits + some details in contributing it should be good to go |
…from requirements
I've just added some docs and ceilings for the versions in |
Solid! Nice on @adriangonz |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo, cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Resolves #1042. However, before making any changes we should discuss on #1042 if we want to introduce
tox
or not.Changelog
requirements-dev.txt
withpytest
,tox
andmypy
tox
config tosetup.cfg
install-*
targets inMakefile
and the different steps injenkins-x.yaml
since the diff environments are now hanled bytox