Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot config #1041

Merged
merged 1 commit into from
Nov 5, 2019
Merged

Conversation

adriangonz
Copy link
Contributor

Changelog

  • Add dependabot config

@adriangonz
Copy link
Contributor Author

/uncc @gsunner @ryandawsonuk
/cc @axsaucedo @cliveseldon

@seldondev seldondev requested review from axsaucedo and ukclivecox and removed request for gsunner and ryandawsonuk November 4, 2019 17:16
@adriangonz
Copy link
Contributor Author

/approve

@adriangonz
Copy link
Contributor Author

/lgtm

@seldondev
Copy link
Collaborator

@adriangonz: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adriangonz
Copy link
Contributor Author

@axsaucedo I looked in the docs, and there are ways to avoid PRs for patches (it also allows you to auto-merge them). However, I think we should keep them coming so that they flag version requirements which are potentially too strict. In these cases, we then have two options:

  • Manually extending the allowed range, so that all patches are included and no further PRs are needed (e.g. >=1.1.0, <1.2 in Python). This should be the preferred option when the dependencies follow semver.
  • Accept the PR and keep them coming. This makes sense when the packages don't follow semver and even "patches" (what would be patches under semver) need to be tested and pinned down.

@axsaucedo
Copy link
Contributor

/lgtm

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz, axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [adriangonz,axsaucedo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 6327ca0 into SeldonIO:master Nov 5, 2019
@axsaucedo axsaucedo removed their assignment May 13, 2021
@seldondev
Copy link
Collaborator

failed to trigger Pull Request pipeline

  • failed to create agent
  • failed to calculate in repo config
  • failed to load trigger config for repository SeldonIO/seldon-core for ref 1a8c6cd
  • failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha 1a8c6cd
  • failed to process repo SeldonIO/seldon-core refref 1a8c6cd
  • failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
  • open /var/tmp/gitrepo660600678/.lighthouse
  • no such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants