fix: review comments to not to add -s flag

components/tls/Makefile

@@ -18,7 +18,7 @@ lint: ${.GOLANGCILINT_PATH}/golangci-lint
 
 .PHONY: build
 build: test
-	go build -trimpath -ldflags="-s -w" ./pkg/...
+	go build -trimpath -ldflags="-w" ./pkg/...
 
 .PHONY: licenses/dep.txt
 licenses/dep.txt:

hodometer/Makefile

@@ -37,7 +37,7 @@ lint: ${.GOLANGCILINT_PATH}/golangci-lint
 .PHONY: build-hodometer
 build-hodometer: test-hodometer 
 	$(GO_ENV) \
-				go build -trimpath -ldflags="-s -w" \
+				go build -trimpath -ldflags="-w" \
 				-o bin/hodometer \
 				-ldflags=" \
 				-X '$(VERSION_PACKAGE).BuildVersion=$(BUILD_VERSION)' \

operator/Dockerfile

@@ -16,7 +16,7 @@ COPY operator/pkg/ pkg/
 COPY operator/main.go main.go
 
 # Build
-RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -trimpath -ldflags="-s -w" -a -o manager main.go
+RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -trimpath -ldflags="-w" -a -o manager main.go
 
 FROM registry.access.redhat.com/ubi9/ubi-micro:9.4-15
 WORKDIR /

operator/Makefile

@@ -88,20 +88,20 @@ test: manifests generate fmt vet envtest ## Run tests.
 
 .PHONY: build
 build: generate fmt vet ## Build manager binary.
-	go build -trimpath -ldflags="-s -w" -o bin/manager main.go
+	go build -trimpath -ldflags="-w" -o bin/manager main.go
 
 .PHONY: run
 run: manifests generate fmt vet ## Run a controller from your host.
 	go run ./main.go
 
 build-seldon: generate fmt vet
-	go build -trimpath -ldflags="-s -w" -o bin/seldon -v ./cmd/seldon
+	go build -trimpath -ldflags="-w" -o bin/seldon -v ./cmd/seldon
 
 build-seldon-arm: generate fmt vet
-	GOOS=darwin GOARCH=arm64 go build -trimpath -ldflags="-s -w" -tags dynamic -o bin/seldon -v ./cmd/seldon
+	GOOS=darwin GOARCH=arm64 go build -trimpath -ldflags="-w" -tags dynamic -o bin/seldon -v ./cmd/seldon
 
 build-seldon-docgen:
-	go build -trimpath -ldflags="-s -w" -o bin/seldon-gendocs -v ./cmd/seldon/docs
+	go build -trimpath -ldflags="-w" -o bin/seldon-gendocs -v ./cmd/seldon/docs
 
 generate-cli-docs:
 	./bin/seldon-gendocs --out ../docs/source/contents/cli/docs

scheduler/Makefile

@@ -32,31 +32,31 @@ GO_LDFLAGS := -s -w $(patsubst %,-X %, $(GO_BUILD_VARS))
 
 .PHONY: build-scheduler
 build-scheduler: test-go
-	go build -trimpath -ldflags="-s -w" -buildvcs=false -o bin/scheduler ./cmd/scheduler
+	go build -trimpath -ldflags="-w" -buildvcs=false -o bin/scheduler ./cmd/scheduler
 
 .PHONY: build-proxy
 build-proxy: test-go
-	CGO_ENABLED=0 go build -trimpath -ldflags="-s -w" -o bin/proxy ./cmd/proxy
+	CGO_ENABLED=0 go build -trimpath -ldflags="-w" -o bin/proxy ./cmd/proxy
 
 .PHONY: build-agent
 build-agent: test-go
-	CGO_ENABLED=0 go build -trimpath -ldflags="-s -w" -buildvcs=false -o bin/agent ./cmd/agent
+	CGO_ENABLED=0 go build -trimpath -ldflags="-w" -buildvcs=false -o bin/agent ./cmd/agent
 
 .PHONY: build-modelgateway
 build-modelgateway: test-go
-	go build -trimpath -ldflags="-s -w" -o bin/modelgateway -v ./cmd/modelgateway
+	go build -trimpath -ldflags="-w" -o bin/modelgateway -v ./cmd/modelgateway
 
 .PHONY: build-pipelinegateway
 build-pipelinegateway: test-go
-	go build -trimpath -ldflags="-s -w" -o bin/pipelinegateway -v ./cmd/pipelinegateway
+	go build -trimpath -ldflags="-w" -o bin/pipelinegateway -v ./cmd/pipelinegateway
 
 .PHONY: build-dataflow-producer
 build-dataflow-producer: test-jvm
-	go build -trimpath -ldflags="-s -w" -o data-flow/scripts/bin/producer ./data-flow/scripts/producer.go ./data-flow/scripts/common.go
+	go build -trimpath -ldflags="-w" -o data-flow/scripts/bin/producer ./data-flow/scripts/producer.go ./data-flow/scripts/common.go
 
 .PHONY: build-dataflow-consumer
 build-dataflow-consumer:
-	go build -trimpath -ldflags="-s -w" -o data-flow/scripts/bin/consumer ./data-flow/scripts/consumer.go ./data-flow/scripts/common.go
+	go build -trimpath -ldflags="-w" -o data-flow/scripts/bin/consumer ./data-flow/scripts/consumer.go ./data-flow/scripts/common.go
 
 .PHONY: build-dataflow-engine
 build-dataflow-engine: