permission and timeout changes after trying on an openshift4 cluster (#…

…524) permission and timeout changes after trying on an openshift4 cluster
SeldonIO · Apr 24, 2019 · 4529176 · 4529176
1 parent 993a755
commit 4529176
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 4 deletions.
diff --git a/cluster-manager/src/main/java/io/seldon/clustermanager/k8s/SeldonDeploymentOperatorImpl.java b/cluster-manager/src/main/java/io/seldon/clustermanager/k8s/SeldonDeploymentOperatorImpl.java
@@ -139,10 +139,10 @@ private V1.Container createEngineContainer(SeldonDeployment mlDep,PredictorSpec
 					.setTimeoutSeconds(2)
 					)
 			.setLivenessProbe(Probe.newBuilder().setHandler(Handler.newBuilder()
-					.setHttpGet(HTTPGetAction.newBuilder().setPort(IntOrString.newBuilder().setType(1).setStrVal("admin")).setPath("/ready")))
+					.setHttpGet(HTTPGetAction.newBuilder().setPort(IntOrString.newBuilder().setType(1).setStrVal("admin")).setPath("/live")))
 					.setInitialDelaySeconds(20)
 					.setPeriodSeconds(5)
-					.setFailureThreshold(3)
+					.setFailureThreshold(7)
 					.setSuccessThreshold(1)
 					.setTimeoutSeconds(2)
 					)

diff --git a/engine/src/main/java/io/seldon/engine/api/rest/RestClientController.java b/engine/src/main/java/io/seldon/engine/api/rest/RestClientController.java
@@ -62,7 +62,7 @@ public class RestClientController {
 
 	 @PostConstruct
 	 public void init(){
-		 ready.set(true);;
+		 ready.set(true);
 	 }	
 
 	@RequestMapping("/")
@@ -95,7 +95,20 @@ ResponseEntity<String> ready() {
 		ResponseEntity<String> responseEntity = new ResponseEntity<String>(ret, responseHeaders, httpStatus);
 		return responseEntity;
     }
-
+
+	@RequestMapping("/live")
+	ResponseEntity<String> live() {
+
+		HttpHeaders responseHeaders = new HttpHeaders();
+		HttpStatus httpStatus;
+		String ret  = "live";
+		httpStatus = HttpStatus.OK;
+
+		ResponseEntity<String> responseEntity = new ResponseEntity<String>(ret, responseHeaders, httpStatus);
+		return responseEntity;
+	}
+
+
 	@RequestMapping("/pause")
     String pause() {	    
 		ready.set(false);

diff --git a/helm-charts/seldon-core/values.yaml b/helm-charts/seldon-core/values.yaml
@@ -68,4 +68,9 @@ redis:
   usePassword: false
   cluster:
     enabled: false
+  securityContext:
+    enabled: false
+  master:
+    securityContext:
+      enabled: false
 single_namespace: true