Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump tensorflow to 2.12 #896

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Bump tensorflow to 2.12 #896

merged 1 commit into from
Apr 17, 2023

Conversation

ascillitoe
Copy link
Contributor

@ascillitoe ascillitoe commented Apr 5, 2023

See SeldonIO/alibi-detect#764 (comment) for summary of important changes in 2.12.

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #896 (37c385c) into master (edffde0) will increase coverage by 0.11%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #896      +/-   ##
==========================================
+ Coverage   85.22%   85.33%   +0.11%     
==========================================
  Files          74       74              
  Lines        8762     8802      +40     
==========================================
+ Hits         7467     7511      +44     
+ Misses       1295     1291       -4     
Flag Coverage Δ
macos-latest-3.10 85.19% <ø> (?)
ubuntu-latest-3.10 85.19% <ø> (?)
ubuntu-latest-3.7 85.19% <ø> (?)
ubuntu-latest-3.8 85.22% <ø> (+0.09%) ⬆️
ubuntu-latest-3.9 85.22% <ø> (+0.09%) ⬆️
windows-latest-3.9 82.88% <ø> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes

@jklaise
Copy link
Contributor

jklaise commented Apr 6, 2023

Looks like 2.12 pulls in both jax and ml-dtypes which is curious. Also noting that there is no licence change for alibi-detect (meaning those two were already pulled in previously?).

@ascillitoe
Copy link
Contributor Author

ascillitoe commented Apr 6, 2023

Looks like 2.12 pulls in both jax and ml-dtypes which is curious. Also noting that there is no licence change for alibi-detect (meaning those two were already pulled in previously?).

I think jax uses ml-dtypes, and I know tf 2.7 added this "Add experimental API experimental_from_jax to support conversion from Jax models to TensorFlow Lite", but confused why the jax licence is only being added now...

Edit: Apache 2.0 licence is OK though isn't it?

@jklaise jklaise merged commit 1cc542c into master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants