Included 'start_label' for 'slic' segmentation. #753
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest releases of
skimage
updated theslic
default indexing to start from 1 instead of 0 for convention reasons. This conflicts with thealibi
expectation which assumes that the indexing starts from 0.This PR addresses this issue by forcing the
slic
segmentation indexing to start from 0 through the argumentstart_label=0
. The defaultslic
kwargs were updated withstart_label=0
as well as the arguments in the example notebook. The docstring were updated as well to describealibi
expectation of the segmentation indexing. Those updates required a bump in thesklearn
verison to a lower bound version of 0.17.2 (the stable version of 0.17.X).Addresses issue #748