Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove explicit dependency #1002

Merged
merged 1 commit into from
Mar 8, 2024
Merged

fix: Remove explicit dependency #1002

merged 1 commit into from
Mar 8, 2024

Conversation

jesse-c
Copy link
Contributor

@jesse-c jesse-c commented Mar 8, 2024

It's not directly used. Relax the constraint, so the package can be used elsewhere.

Update: Let the resolver work it out.

Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.23%. Comparing base (8a1eb1c) to head (57406f2).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1002   +/-   ##
=======================================
  Coverage   85.23%   85.23%           
=======================================
  Files          74       74           
  Lines        8834     8834           
=======================================
  Hits         7530     7530           
  Misses       1304     1304           

Copy link
Collaborator

@mauicv mauicv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor point that i'm not too fussed about but otherwise LGTM!

setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
Let the resolver work it out.
@jesse-c jesse-c changed the title fix: Relax Pydantic version constraint fix: Remove explicit dependency Mar 8, 2024
@mauicv mauicv merged commit ab0b6a6 into SeldonIO:master Mar 8, 2024
14 checks passed
@jesse-c jesse-c deleted the bump-pydantic-v2 branch March 8, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants