Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI/CD macos-huggingface #1805

Merged

Conversation

RobertSamoilescu
Copy link
Contributor

@RobertSamoilescu RobertSamoilescu commented Jun 14, 2024

This PR fixes macos - huggingface CI. torch no longer supports macos x86 (see issue here)

@RobertSamoilescu RobertSamoilescu force-pushed the fix/macos-huggingface-ci branch 4 times, most recently from 2562f3a to d08fd2a Compare June 14, 2024 08:13
@RobertSamoilescu RobertSamoilescu force-pushed the fix/macos-huggingface-ci branch 3 times, most recently from 1604b79 to e526405 Compare June 14, 2024 10:35
@RobertSamoilescu RobertSamoilescu force-pushed the fix/macos-huggingface-ci branch from e526405 to 56d46f2 Compare June 14, 2024 10:37
@sakoush sakoush self-requested a review June 14, 2024 13:18
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@RobertSamoilescu RobertSamoilescu force-pushed the fix/macos-huggingface-ci branch from ccf3c90 to 5b949f2 Compare June 14, 2024 13:39
@RobertSamoilescu RobertSamoilescu force-pushed the fix/macos-huggingface-ci branch from 5b949f2 to d70b1e5 Compare June 14, 2024 13:46
@RobertSamoilescu RobertSamoilescu merged commit d3c12b6 into SeldonIO:master Jun 14, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants