Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Upgrade stale packages (fastapi, starlette, tensorflow, torch) #1603

Merged
merged 15 commits into from
Mar 1, 2024
Merged

build: Upgrade stale packages (fastapi, starlette, tensorflow, torch) #1603

merged 15 commits into from
Mar 1, 2024

Conversation

sakoush
Copy link
Member

@sakoush sakoush commented Mar 1, 2024 •
edited
Loading

This is a change to upgrade deps of mlserver that was triggered by initially trying to update fastapi to a recent version. Due to some deps clashed we had to:

  • remove py3.8 support: a few packages already require py3.9 as minimum version (e.g. numpy and tensorflow). py3.8 EoL is October 2024.
  • update packages to more recent versions e.g. numpy 1.26.4, tensorflow 2.14.1 and torch 2.2.1.
  • update mypy to 1.8.0 to fix issues from starlette 0.36.3 upgrade
  • fix tests from fastapi upgrade to 1.109.2

For a full list of changes check pyproject.toml and poetry.lock

@sakoush sakoush marked this pull request as draft March 1, 2024 10:34
@sakoush sakoush marked this pull request as ready for review March 1, 2024 10:49
@sakoush sakoush requested a review from RafalSkolasinski March 1, 2024 10:50
@sakoush sakoush changed the title build: Upgrade state packages (fastapi, starlette, tensorflow, torch) build: Upgrade stale packages (fastapi, starlette, tensorflow, torch) Mar 1, 2024
RafalSkolasinski
RafalSkolasinski approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@RafalSkolasinski RafalSkolasinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just clarification on some choices would be good :)

@sakoush
Copy link
Member Author

sakoush commented Mar 1, 2024

skipping flaky tests for now

@sakoush sakoush merged commit 05d6a0c into SeldonIO:master Mar 1, 2024
18 of 20 checks passed
@RafalSkolasinski RafalSkolasinski mentioned this pull request Mar 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafalSkolasinski RafalSkolasinski RafalSkolasinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sakoush @RafalSkolasinski