Deprecate DateTimeImmutable #1928
Conversation
|
Thanks |
|
FYI, citing https://semver.org/
|
|
Not sure what you're trying to say? |
|
New version should have been 3.9.0, not 3.8.1 |
|
Ah I see. Yeah that was a mistake rushing this release while sitting at SymfonyCon. |
| $this->useMicroseconds = $useMicroseconds; | ||
|
|
||
| // if you like to use a custom time to pass to Logger::addRecord directly, | ||
| // call modify() or setTimestamp() on this instance to change the date after creating it |
There was a problem hiding this comment.
Doesn't immutable mean that you can't modify the instance?
I tested locally, and setTimestamp does nothing, I was expecting it to throw.
$ php -r '$t = new \DateTimeImmutable(); $t->setTimestamp(123); echo PHP_VERSION, "\n", $t->getTimestamp(), "\n";'
8.4.2
1735898810
There was a problem hiding this comment.
This class behaves the same as DateTime except new objects are returned when modification methods such as DateTime::modify() are called.
There was a problem hiding this comment.
You need to use the instance returned by setTimestamp and pass that to Logger::addRecord as custom datetime instance.
Fixes #1926