Fix ErrorHandler::handleError signature: make $context nullable #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The context can be null, eg. for internal PHP errors.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the PHP docs don't mention it, the error context can be null. We just experienced this with a failing
getaddrinfocall from an internal PHP function during shutdown, which triggered a warning, which in turn crashed the Monolog error handler.A more in-depth explanation for this fix can be found in the Sentry repo, where the same problem was fixed a while back: getsentry/sentry-php#912 (comment)
Note that this is only relevant for PHP<=7, as the context parameter has been removed in PHP8.
Thanks in advance!