Add QR brightness tips screen #389

overcat · 2023-06-13T02:34:31Z

resolve #363

jdlcdl · 2023-06-13T16:02:50Z

Concept ACK, at the least, and tested
...however I'd personally prefer 3s instead of 2s for the delay. Just my 2c.

I think that this may actually resolve an issue where we've considered changing the default brightness (#377 and #380), because as long as the user knows how to do this, we might not need to default to a strangely dark qrcode background.

Also, I really like that there is an Advanced Settings option to disable QR brightness tips, and that it's default=enabled so that new users will see it; they can disable these notices once they learn how important it is.

newtonick · 2023-06-13T17:33:48Z

Concept ACK

SmokeTag · 2023-06-25T09:24:45Z

ACK tested

When testing I tried pressing one of the push buttons during the QR brightness tip screen which resulted in skipping the QR instead of skipping the brightness tip screen.

overcat · 2023-06-25T09:29:21Z

ACK tested

When testing I tried pressing one of the push buttons during the QR brightness tip screen which resulted in skipping the QR instead of skipping the brightness tip screen.

Thank you, I can reproduce it and will fix it as soon as possible.

…ing from the QR code page.

jdlcdl · 2023-06-25T12:56:37Z

Well done @SmokeTag for catching that! I was able to confirm as well.

and @overcat, I confirm that your latest commit 1e11f09 corrects it.
Also, I like the extra second for time to read the message.

newtonick · 2023-06-29T21:25:31Z

ACK Tested

kdmukai · 2023-06-30T14:22:19Z

I think any new UI element (esp if it isn't just a standard ButtonListScreen should have images or a video demo in the PR.

20230630_091655_edit.mp4

overcat · 2023-06-30T14:24:24Z

I think any new UI element (esp if it isn't just a standard ButtonListScreen should have images or a video demo in the PR.

20230630_091655_edit.mp4

Thank you for your reminder. I will follow this point in future PRs.

easyuxd · 2023-06-30T19:41:44Z

Super useful feature. Thanks, @overcat!

Possible enhancement: I'm thinking it could be helpful to provide the help text in context of the QR code rather than introducing a separate (blank) screen, so I put together a couple quick mocks. Thoughts?

@kdmukai, I'm trying to recall if this is what the latest snackbar component looks like. Do you have an example from the current build?

newtonick · 2023-07-01T03:31:50Z

Possible enhancement: I'm thinking it could be helpful to provide the help text in context of the QR code rather than introducing a separate (blank) screen, so I put together a couple quick mocks. Thoughts?

I like the Brightness Up/Down screen on the left. I think this could be implemented as a GUI component that renders for both static and animated QRs. @easyuxd how do you imagine this help text disappearing/fading out? I think it would be nice for it to flash up for about 1 second and fade out quickly when any QR initially is displayed. Then when the brightness is changed (up or down) it would display again for 1 second and fade out again.

easyuxd · 2023-07-01T04:01:07Z

I love your idea, @newtonick.

Here's what it would look like if the snackbar/overlay holds on screen for 1000ms and fades in/out with a standard 300ms transition.

overcat · 2023-07-02T15:20:04Z

Hi @easyuxd, if it is an animated QR code, should the QR code change when the snackbar/overlay appears, or should it remain unchanged?

kdmukai · 2023-07-02T16:12:48Z

@easyuxd food for thought (I am in no way convinced this is necessarily a better word choice, though!):

^ Brighter
⌄ Darker

Or perhaps "Dimmer".

easyuxd · 2023-07-02T16:19:58Z

Hi @easyuxd, if it is an animated QR code, should the QR code change when the snackbar/overlay appears, or should it remain unchanged?

@overcat -- I don't see a reason why the behavior would change. The QR code would continue to animate as usual while the overlay appears momentarily.

^ Brighter
⌄ Darker

@kdmukai Certainly more succinct! Increase/decrease brightness is another option. I don't have a strong preference, myself. Which language are users going to best associate with screen brightness (and when localized to other languages)?

overcat · 2023-07-03T09:47:07Z

Hi @easyuxd, if it is an animated QR code, should the QR code change when the snackbar/overlay appears, or should it remain unchanged?

@overcat -- I don't see a reason why the behavior would change. The QR code would continue to animate as usual while the overlay appears momentarily.

OK, I raised this question because we now have ToastOverlay, but when it appears, the animated QR code does not change.

easyuxd · 2023-07-03T15:14:14Z

OK, I raised this question because we now have ToastOverlay, but when it appears, the animated QR code does not change.

@overcat Thanks for the context. What's the difference between Snackbar and Toast? Do you have a toast example (visual/interaction) you can share?

overcat · 2023-07-03T15:31:24Z

OK, I raised this question because we now have ToastOverlay, but when it appears, the animated QR code does not change.

@overcat Thanks for the context. What's the difference between Snackbar and Toast? Do you have a toast example (visual/interaction) you can share?

When you insert/remove the SD card, you will see this toast.

IMG_0088.mov

easyuxd · 2023-07-03T21:29:16Z

@overcat Thanks for the visual aid -- super helpful.

We don't need to interrupt the experience unless there's rationale supporting it, like system messaging that users must dismiss. And messaging like this is currently done using Dialogs today so that we can include CTAs:

If we think we have 2 distinct messaging use cases that require nuanced interactions (see toast vs snackbar) I'd propose 2 variants of the component:

Messaging-Toast

System messaging
Non-dismissable
Interrupts experience

Messaging-Snackbar:

Task-related messaging
Dismissable
Does not interrupt experience

Otherwise (and I think this would be much simpler), we could just align the SD Card messaging with the single messaging component behavior proposed in this PR and have one global messaging component everywhere. This would mean not interrupting users when they add/remove an SD card.

overcat · 2023-07-09T09:22:09Z

Hi, I have made some updates and here is the video presentation: ~~https://imgur.com/a/15OjKmH~~

~~l don't know why I can't upload videos smoothly on GitHub :-(~~

IMG_0091.mov

kdmukai · 2023-07-15T16:00:05Z

Note: suggested refactoring and UI improvements submitted here: overcat#1

kdmukai · 2023-07-15T16:00:44Z

20230715_093853_edit.mp4

* Refactor to use existing components * final tweaks * Update screen.py * Adding comments, TODO

kdmukai · 2023-07-16T12:45:23Z

ACK on the latest version of this (incorporates my suggested refactoring and UI tweaks)!!

jdlcdl · 2023-07-16T16:50:55Z

ACK ef70a8d

It's looking very nice.

newtonick · 2023-07-20T20:15:52Z

ACK and tested! Awesome work!

Add QR brightness tips screen

4833bff

Set the displayed time to 3 seconds.

49aeaa8

Fix the issue where clicking a button on the tips page may cause exit…

1e11f09

…ing from the QR code page.

newtonick self-requested a review June 29, 2023 02:21

newtonick added the enhancement New feature or request label Jun 29, 2023

newtonick added this to the 0.6.1 milestone Jun 29, 2023

Use Toast to display the brightness tip

b232e22

Refactoring PR SeedSigner#389 (#1)

ef70a8d

* Refactor to use existing components * final tweaks * Update screen.py * Adding comments, TODO

Merge branch 'dev' into qr-brightness-tips

0710062

newtonick merged commit 013dd50 into SeedSigner:dev Jul 20, 2023

easyuxd mentioned this pull request Aug 4, 2023

SeedSigner Icons v2 #423

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add QR brightness tips screen #389

Add QR brightness tips screen #389

overcat commented Jun 13, 2023 •

edited

Loading

jdlcdl commented Jun 13, 2023

newtonick commented Jun 13, 2023

SmokeTag commented Jun 25, 2023

overcat commented Jun 25, 2023

jdlcdl commented Jun 25, 2023

newtonick commented Jun 29, 2023

kdmukai commented Jun 30, 2023

overcat commented Jun 30, 2023

easyuxd commented Jun 30, 2023

newtonick commented Jul 1, 2023

easyuxd commented Jul 1, 2023

overcat commented Jul 2, 2023

kdmukai commented Jul 2, 2023 •

edited

Loading

easyuxd commented Jul 2, 2023

overcat commented Jul 3, 2023

easyuxd commented Jul 3, 2023

overcat commented Jul 3, 2023

easyuxd commented Jul 3, 2023 •

edited

Loading

overcat commented Jul 9, 2023 •

edited

Loading

kdmukai commented Jul 15, 2023

kdmukai commented Jul 15, 2023

kdmukai commented Jul 16, 2023

jdlcdl commented Jul 16, 2023

newtonick commented Jul 20, 2023

Add QR brightness tips screen #389

Add QR brightness tips screen #389

Conversation

overcat commented Jun 13, 2023 • edited Loading

jdlcdl commented Jun 13, 2023

newtonick commented Jun 13, 2023

SmokeTag commented Jun 25, 2023

overcat commented Jun 25, 2023

jdlcdl commented Jun 25, 2023

newtonick commented Jun 29, 2023

kdmukai commented Jun 30, 2023

overcat commented Jun 30, 2023

easyuxd commented Jun 30, 2023

newtonick commented Jul 1, 2023

easyuxd commented Jul 1, 2023

overcat commented Jul 2, 2023

kdmukai commented Jul 2, 2023 • edited Loading

easyuxd commented Jul 2, 2023

overcat commented Jul 3, 2023

easyuxd commented Jul 3, 2023

overcat commented Jul 3, 2023

easyuxd commented Jul 3, 2023 • edited Loading

overcat commented Jul 9, 2023 • edited Loading

kdmukai commented Jul 15, 2023

kdmukai commented Jul 15, 2023

kdmukai commented Jul 16, 2023

jdlcdl commented Jul 16, 2023

newtonick commented Jul 20, 2023

overcat commented Jun 13, 2023 •

edited

Loading

kdmukai commented Jul 2, 2023 •

edited

Loading

easyuxd commented Jul 3, 2023 •

edited

Loading

overcat commented Jul 9, 2023 •

edited

Loading