Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getUserByEmail query #3339

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Add getUserByEmail query #3339

merged 2 commits into from
Dec 18, 2024

Conversation

bryanjnelson
Copy link
Contributor

Copy link

coderabbitai bot commented Dec 12, 2024

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Dec 12, 2024

🗞 GraphQL Summary

View schema changes
@@ -5293,8 +5293,11 @@
 
   """Look up a user by its ID"""
   user(id: ID!): User!
 
+  """Returns a user for a given email address"""
+  userByEmail(email: String!): User
+
   """Look up users"""
   users(input: UserListInput = {count: 25, order: ASC, page: 1, sort: "id"}): UserListOutput!
   wait(delay: String!): Boolean!
 }

@bryanjnelson bryanjnelson force-pushed the 0322-user-by-email-query branch 2 times, most recently from d116ee6 to 4cae7d0 Compare December 17, 2024 18:04
@bryanjnelson
Copy link
Contributor Author

@CarsonF - Can you throw a 🦴 on that type error in the EdgeDB repo?

@CarsonF
Copy link
Member

CarsonF commented Dec 18, 2024

@CarsonF - Can you throw a 🦴 on that type error in the EdgeDB repo?

You're returning { dto: User } from the neo4j repo. Unwrap it.

@bryanjnelson bryanjnelson force-pushed the 0322-user-by-email-query branch from 4cae7d0 to 525424e Compare December 18, 2024 20:20
@CarsonF
Copy link
Member

CarsonF commented Dec 18, 2024

Ok I think I made a miss here. The checkEmail is anonymous, no access policies. The new method is with access policies, so they cannot be combined.

@bryanjnelson
Copy link
Contributor Author

So it doesn't work to just call it with that anonymous session?

@CarsonF CarsonF force-pushed the 0322-user-by-email-query branch from 525424e to bb9b79c Compare December 18, 2024 22:28
@CarsonF
Copy link
Member

CarsonF commented Dec 18, 2024

So it doesn't work to just call it with that anonymous session?

It could be fine for Neo4j, but not EdgeDB.

@bryanjnelson bryanjnelson requested a review from CarsonF December 18, 2024 23:02
@CarsonF CarsonF merged commit f802e63 into develop Dec 18, 2024
17 checks passed
@CarsonF CarsonF deleted the 0322-user-by-email-query branch December 18, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants