Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0573 Location.defaultMarketingRegion #2987

Merged
merged 8 commits into from
Jan 16, 2024

Conversation

willdch
Copy link
Contributor

@willdch willdch commented Dec 15, 2023

https://seed-company-squad.monday.com/boards/3451697530/pulses/4875988786

More to do here but this PR addresses the bullet point below taken from the linked Monday ticket.

  • Add Location.marketingRegion: Location (3)

┆Issue is synchronized with this Monday item by Unito

@willdch willdch requested a review from bryanjnelson December 15, 2023 00:28
@willdch willdch requested a review from CarsonF as a code owner December 15, 2023 00:28
Copy link

github-actions bot commented Dec 15, 2023

🗞 GraphQL Summary

View schema changes
@@ -718,8 +718,9 @@
 }
 
 input CreateLocation {
   defaultFieldRegionId: ID
+  defaultMarketingRegionId: ID
   fundingAccountId: ID
 
   """An ISO 3166-1 alpha-3 country code"""
   isoAlpha3: String
@@ -2498,8 +2499,9 @@
   """Whether the requesting user can delete this resource"""
   canDelete: Boolean!
   createdAt: DateTime!
   defaultFieldRegion: SecuredFieldRegion!
+  defaultMarketingRegion: SecuredLocation!
   fundingAccount: SecuredFundingAccount!
   id: ID!
   isoAlpha3: SecuredStringNullable!
 
@@ -6741,8 +6743,9 @@
 }
 
 input UpdateLocation {
   defaultFieldRegionId: ID
+  defaultMarketingRegionId: ID
   fundingAccountId: ID
   id: ID!
 
   """An ISO 3166-1 alpha-3 country code"""

⚠️ Dangerous Changes

  • An optional field defaultMarketingRegionId on input type CreateLocation was added.
  • An optional field defaultMarketingRegionId on input type UpdateLocation was added.

src/components/location/location.repository.ts Outdated Show resolved Hide resolved
src/components/location/location.repository.ts Outdated Show resolved Hide resolved
@willdch willdch requested a review from bryanjnelson December 21, 2023 23:35
@bryanjnelson
Copy link
Contributor

Thanks @willdch! @CarsonF, over to you for review.

Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed offline. Rename to defaultMarketingRegion following suit of defaultFieldRegion

test/utility/fragments.ts Outdated Show resolved Hide resolved
@willdch willdch force-pushed the 0573-update-Marketing-Region-and-Location branch from 3beea6b to 04d4bdb Compare January 4, 2024 17:49
Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source looks good! Just some notes on the tests

test/utility/fragments.ts Outdated Show resolved Hide resolved
test/utility/fragments.ts Outdated Show resolved Hide resolved
test/utility/fragments.ts Outdated Show resolved Hide resolved
test/utility/fragments.ts Show resolved Hide resolved
@willdch willdch requested a review from bryanjnelson January 5, 2024 21:18
test/location.e2e-spec.ts Outdated Show resolved Hide resolved
@willdch willdch force-pushed the 0573-update-Marketing-Region-and-Location branch from 7ef6a56 to 9917765 Compare January 5, 2024 22:57
@willdch willdch requested a review from CarsonF January 5, 2024 23:12
@willdch willdch self-assigned this Jan 11, 2024
@CarsonF CarsonF changed the title 0573 update marketing region and location 0573 Location.defaultMarketingRegion Jan 16, 2024
test/location.e2e-spec.ts Outdated Show resolved Hide resolved
Copy link
Member

@CarsonF CarsonF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good guys, thanks!

@CarsonF CarsonF enabled auto-merge (squash) January 16, 2024 15:51
@CarsonF CarsonF merged commit 1bbaab1 into develop Jan 16, 2024
15 checks passed
@CarsonF CarsonF deleted the 0573-update-Marketing-Region-and-Location branch January 16, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants