-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0573 Location.defaultMarketingRegion #2987
Conversation
🗞 GraphQL SummaryView schema changes@@ -718,8 +718,9 @@
}
input CreateLocation {
defaultFieldRegionId: ID
+ defaultMarketingRegionId: ID
fundingAccountId: ID
"""An ISO 3166-1 alpha-3 country code"""
isoAlpha3: String
@@ -2498,8 +2499,9 @@
"""Whether the requesting user can delete this resource"""
canDelete: Boolean!
createdAt: DateTime!
defaultFieldRegion: SecuredFieldRegion!
+ defaultMarketingRegion: SecuredLocation!
fundingAccount: SecuredFundingAccount!
id: ID!
isoAlpha3: SecuredStringNullable!
@@ -6741,8 +6743,9 @@
}
input UpdateLocation {
defaultFieldRegionId: ID
+ defaultMarketingRegionId: ID
fundingAccountId: ID
id: ID!
"""An ISO 3166-1 alpha-3 country code"""
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed offline. Rename to defaultMarketingRegion
following suit of defaultFieldRegion
3beea6b
to
04d4bdb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Source looks good! Just some notes on the tests
7ef6a56
to
9917765
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good guys, thanks!
https://seed-company-squad.monday.com/boards/3451697530/pulses/4875988786
More to do here but this PR addresses the bullet point below taken from the linked Monday ticket.
┆Issue is synchronized with this Monday item by Unito