This repository has been archived by the owner on Apr 19, 2021. It is now read-only.
Avoid hard loop when file unavailable #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the download is not available, this script gets stuck in a hard loop retrying, filling up both logfiles and bandwidth to a proxy. This patch neuters the retry attempt by just continuing on.
|
Thanks, @petiepooo ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the download is not available, this script gets stuck in a hard loop retrying, filling up both logfiles and bandwidth to a proxy. This patch neuters the retry attempt by just continuing on.
To test, try sinkholing the ftp.afrinic.org IP and running the weekly cron task.. Alternatively, if you use a proxy such as squid3 (like I do), disable the ftp protocol for the test duration.
This can become an issue for sensors that do not have direct internet access.