Fix Always Passing Date Parameters to Backend #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old approach took advantage of the fact that undefined properties, when converted to JSON, are left out. The updated approach always specified the `beginDate` and `endDate` fields, if no value was entered by the user an empty string was used and this threw a 400 from the backend because they don't parse as a valid date. The new approach conditionally adds them if the user set their values. Added a regression test.
jertel
approved these changes
Mar 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old approach took advantage of the fact that undefined properties, when converted to JSON, are left out. The updated approach always specified the
beginDateandendDatefields, if no value was entered by the user an empty string was used and this threw a 400 from the backend because they don't parse as a valid date. The new approach conditionally adds them if the user set their values.Added a regression test.