PCAP Date Picker #758
Merged
PCAP Date Picker #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace "start time" and "end time" inputs on the New Job dialog with a single input powered by the same DateRangePicker we use elsewhere in SOC. Updated golang.org/x/crypto version in response to a discovered vulnerability.
Fixed a bug where `timeframe` was assumed to be filled out even though it might not be. New test. Preformatted the dates instead of passing date objects in the API request payload. Removed unused functions getStartDate and getEndDate. Splitting and then parsing/formatting with moment gives more consistent results that don't fall back to a default value. Fixed how we import moment so we have moment+timezones. Removed polyfills. Set timezone to UTC for deterministic tests.
coreyogburn
force-pushed
the
cogburn/new-pcap-calendar
branch
from
736088e to
ad1edbb
Compare
jertel
approved these changes
Feb 28, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace "start time" and "end time" inputs on the New Job dialog with a single input powered by the same DateRangePicker we use elsewhere in SOC.
Updated golang.org/x/crypto version in response to a discovered vulnerability.