Cogburn/refactor changed by user #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkChangedByUser being a context value is being deprecated for a transient field on detections called PersistChange. Todo: Test.
… for detections. We'd set the value, update the detection, overwrite the detection with the result returned from the update that doesn't have the transient value set, then sync with PersistChange = false. Fixed. When walking back the MarkChangedByUser context changes, the migration was updated to use context.Background. Instead we should use the server context, just don't call MarkChangedByUser on it.
jertel
approved these changes
Aug 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed context approach to indicating a change to a detection needs to stick. Instead we can now mark the detection itself using the transient (i.e. never returned to user, never stored in ES) bool field
PersistChange. This field is respected by Suricata and will put the rule in the correct pillar file rather than relying on the community rule's commented-in/commented-out status in rules file.