Respond to IndexNotFound Exception #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On first run, the so-detection index won't be created until the first detection is inserted. This means all calls to GetAllDetections were erroring out. A recent refactor ensured any errors were definitely being captured and as a result this exception was bubbling up and causing all syncs to fail. Now when we run into this case, we log that we noticed the error but we return an empty result set without any error. This will allow syncs to continue and insert their first batch, afterwards everything returns to normal. Added a test for this use case.
defensivedepth
approved these changes
Jul 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On first run, the so-detection index won't be created until the first detection is inserted. This means all calls to GetAllDetections were erroring out. A recent refactor limited the number of indexes on this query and ensured any errors were definitely being captured and as a result this new exception was bubbling up and causing all syncs to fail.
Now when we run into this case, we log that we noticed the error but we return an empty result set without any error. This will allow syncs to continue and insert their first batch, afterwards everything returns to normal.
Added a test for this use case.