Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added .d.ts extension to import type #398

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Added .d.ts extension to import type #398

merged 1 commit into from
Jan 2, 2025

Conversation

Secreto31126
Copy link
Owner

@Secreto31126 Secreto31126 commented Jan 2, 2025

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm run test and lint the project with npm run lint and npm run prettier

As recommended in #376, I tested the library with https://arethetypeswrong.github.io/, and adding the .d.ts file extensions makes the 🥴 go away, so yeah, I think this is a keeper.

Copy link

github-actions bot commented Jan 2, 2025

Visit the preview URL for this PR (updated for commit 59fc38d):

https://whatsappapijs--pr398-test-extension-k6d9ev70.web.app

(expires Thu, 09 Jan 2025 08:08:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 80a8dc4ceea5c783aae1d47b75797ee5b6c2f4be

@Secreto31126 Secreto31126 merged commit 2c3787d into main Jan 2, 2025
15 checks passed
@Secreto31126 Secreto31126 deleted the test-extension branch January 2, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant