Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes #1361

Merged
merged 5 commits into from
May 14, 2023
Merged

Some fixes #1361

merged 5 commits into from
May 14, 2023

Conversation

jbrichau
Copy link
Member

@jbrichau jbrichau commented May 14, 2023

Fixes #1326, #1360, #1359

Also disables the CORS functional webtest since it started failing in the github builds only...

@codecov
Copy link

codecov bot commented May 14, 2023

Codecov Report

Patch coverage: 16.66% and project coverage change: -0.08 ⚠️

Comparison is base (1f56b5d) 54.20% compared to head (5e7a990) 54.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1361      +/-   ##
==========================================
- Coverage   54.20%   54.13%   -0.08%     
==========================================
  Files        8870     8870              
  Lines       72019    72018       -1     
==========================================
- Hits        39041    38989      -52     
- Misses      32978    33029      +51     
Impacted Files Coverage Δ
...e.package/JSJsonParser.class/class/isDeprecated.st 0.00% <0.00%> (ø)
...ackage/WAWelcomeFiles.class/instance/welcomeCss.st 0.00% <0.00%> (ø)
...ctionalTestCase.class/instance/expectedFailures.st 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jbrichau jbrichau merged commit 9866f65 into master May 14, 2023
@jbrichau jbrichau deleted the somefixes branch May 14, 2023 13:47
@jbrichau jbrichau restored the somefixes branch June 3, 2023 15:37
@jbrichau jbrichau deleted the somefixes branch June 3, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GRPlatform >> #sourceFileEncoding is unused
1 participant