New-control-panel-in-spec2

[jecisc]

Introduce a new Control panel in Spec 2 for Pharo 8 +

[theseion]

Very cool!

One thing only: for me the icon in the menu is missing.

[jecisc]

This is weird because I have the icon and I don't see what might be the problem :(

[theseion]

The icon isn't being properly registered. The method on ThemeIcons is never executed.

[jecisc]

Should be fixes

[theseion]

Prefect, thanks!

[marschall]

This causes the Squeak builds to fail because we send SystemVersion>>major

The base branch was changed.

[jbrichau]

I'm trying to recover these changes and get them into master. I never investigated in detail but always thought the PR was blocked with requested changes... I have the impression they have been resolved...?

[jbrichau]

shouldn't this be self pharoVersionsFrom: 8 ?
(not sure if I like this way, but for sure it's where the travis builds fail on...)

[jbrichau]

@jecisc if possible, could you just change it to pharo8? I prefer to manually update for new versions rather than trying to figure out later on if some package should have a self pharoVersionsBetween: xx and: yy method :)

[jbrichau]

I forgot I can very easily complete this myself by merging it into another branch first and make the necessary changes. Going ahead with that.

[jecisc]

Hi @jbrichau
Thank you for taking care of that! Was a little busy this week end and you were faster than me to update the baseline :)

For info: When I do a PR I let the maintainers of the projects edit my PR. This means that you can checkout my branch, change it and push directly on the branch in my fork and it will update the current PR without the need of creating a new one.

[jbrichau]

@jecisc I did not try to see if I could write to your branch, so the easiest for me was to quickly pull it into another branch.
There still is an issue though: #1214 (comment)

I don't know if you have seen that before and what the best way to prevent it is?

(it's the same issue as raised by Max before)