Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Open button to open the webbrowser from control panel #1080

Closed
wants to merge 1 commit into from
Closed

Add an Open button to open the webbrowser from control panel #1080

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions repository/Seaside-Pharo-Tools-Spec.package/GRPackage.extension/methodProperties.json
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions repository/Seaside-Pharo-Tools-Spec.package/ThemeIcons.extension/methodProperties.json
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion ...ro-Tools-Spec.package/WAPharoServerAdapterSpecBrowser.class/instance/adaptorsMenuMorph.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
as yet unclassified
accessing
adaptorsMenuMorph
| aMenu |
aMenu := MenuModel new.
Expand Down
36 changes: 0 additions & 36 deletions ...side-Pharo-Tools-Spec.package/WAPharoServerAdapterSpecBrowser.class/methodProperties.json
View file
Open in desktop

This file was deleted.

3 changes: 2 additions & 1 deletion ...sitory/Seaside-Pharo-Tools-Spec.package/WAServerAdapterToolbar.class/class/defaultSpec.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,6 @@ defaultSpec
row
add: #(model startButton);
add: #(model stopButton);
add: #(model browseButton) ];
add: #(model browseButton);
add: #(model openButton) ];
yourself
3 changes: 2 additions & 1 deletion ...tory/Seaside-Pharo-Tools-Spec.package/WAServerAdapterToolbar.class/instance/initialize.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ initialize
super initialize.
startAction := [ true ] asValueHolder.
stopAction := [ true ] asValueHolder.
browseAction := [ true ] asValueHolder
browseAction := [ true ] asValueHolder.
openAction := [ true ] asValueHolder
9 changes: 6 additions & 3 deletions ...aside-Pharo-Tools-Spec.package/WAServerAdapterToolbar.class/instance/initializeWidgets.st
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,17 @@ initializeWidgets
self instantiateModels: #(
startButton ButtonModel
stopButton ButtonModel
browseButton ButtonModel).
browseButton ButtonModel
openButton ButtonModel).

self registerStartButtonEvents.
self registerStopButtonEvents.
self registerBrowseButtonEvents.

self registerOpenButtonEvents.

self focusOrder
add: startButton;
add: stopButton;
add: browseButton
add: browseButton;
add: openButton

10 changes: 10 additions & 0 deletions ...ory/Seaside-Pharo-Tools-Spec.package/WAServerAdapterToolbar.class/instance/openAdaptor.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
actions
openAdaptor

| postfix |
self owner adaptor ifNotNil: [ :adaptor |
adaptor isRunning ifFalse: [ ^false ].
postfix := adaptor port = 80
ifTrue: [ '']
ifFalse: [ ':', adaptor port asString ].
WebBrowser openOn: 'http://localhost', postfix ]
3 changes: 3 additions & 0 deletions ...tory/Seaside-Pharo-Tools-Spec.package/WAServerAdapterToolbar.class/instance/openButton.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
accessing
openButton
^ openButton
8 changes: 8 additions & 0 deletions ...haro-Tools-Spec.package/WAServerAdapterToolbar.class/instance/registerOpenButtonEvents.st
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
private
registerOpenButtonEvents

openButton
label: 'Open';
enabled: true;
action: [ self openAdaptor ];
state: false
19 changes: 0 additions & 19 deletions ...itory/Seaside-Pharo-Tools-Spec.package/WAServerAdapterToolbar.class/methodProperties.json
View file
Open in desktop

This file was deleted.

4 changes: 3 additions & 1 deletion repository/Seaside-Pharo-Tools-Spec.package/WAServerAdapterToolbar.class/properties.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
"browseButton",
"startAction",
"stopAction",
"browseAction"
"browseAction",
"openButton",
"openAction"
],
"name" : "WAServerAdapterToolbar",
"type" : "normal"
Expand Down
1 change: 0 additions & 1 deletion repository/Seaside-Pharo-Tools-Spec.package/monticello.meta/version
View file
Open in desktop

This file was deleted.