Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup newlines and blanks in "Seaside" packages #1292

Closed
astares opened this issue Dec 8, 2021 · 0 comments · Fixed by #1293
Closed

Cleanup newlines and blanks in "Seaside" packages #1292

astares opened this issue Dec 8, 2021 · 0 comments · Fixed by #1293

Comments

@astares
Copy link
Contributor

astares commented Dec 8, 2021

Similar to what is done in Pharo using pharo-project/pharo#10396
we could remove unnecessary trailing spaces and newlines also at the end of Seaside methods:

We could apply the following script:

badCases := SystemNavigation default allMethodsSelect: [ :each | each sourceCode trimRight size ~= each sourceCode size ].

fixInPackage := badCases select: [:each | each package name beginsWith: 'Seaside' ].

fixInPackage do: [:each |
	| refactoring classOrTrait |
	classOrTrait := each traitSource ifNil: [ each methodClass ] ifNotNil: [ each traitSource innerClass ].
	refactoring := RBAddMethodChange compile: each sourceCode trimRight in: classOrTrait for: nil.				 
	refactoring execute	
]
@astares astares changed the title Cleanup newlines and blanks in "OpalCompiler" packages Cleanup newlines and blanks in "Seaside" packages Dec 8, 2021
astares added a commit to astares/Seaside that referenced this issue Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant