-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WAAnchorTag>>openInNewTab #1124
Comments
We had this in the past and intentionally removed it because it goes against web development best practices, letting the user decide how he wants to open a link. |
I think that in some cases it can be useful because if you have a page with a fork the user need to fill and add a link where the user can get more informations, in any case you do not want to open the link in the current page, else it would discard everything the user already filled. But if you think Seaside should really not implement it I’m fine with it. It’s not hard to find how to do it in case we really need it. |
I'm kinda split. On one hand having it encourages its use on the other hand if people are using it anyway it makes sense to add it. Do you use it in your applications? |
I'm in favour of adding it. Basically, if you need it, you are going to implement it yourself in the same way, so it makes sense to add an abstraction for it to Seaside. Users will most often ask the developer to make certain links open new tabs instead of having them have to do it. |
I use it in one application. Probably in another one later. |
There was a question and two possible solutions recently on the mailinglist: http://lists.squeakfoundation.org/pipermail/seaside/2019-February/033334.html |
@jbrichau I don't know if you saw that I already opened a PR for that. |
@jecisc Yes, I saw it. I just pointed to the discussion, as there is another solution using a presenter (which I need to discover a bit myself what exactly that is doing though..., which is why I put it in here). |
I refreshed my memory on the Now, there are several meanings to the target attribute. My impression is that it would be cleaner if we can add them all instead of just this one (see https://www.w3schools.com/html/html_links.asp). We might also want to avoid using the name 'tab' as it is not guaranteed that a new tab or a new window opens. Suggestions:
|
@jbrichau that makes sense. If I may ask, why |
@marschall typo :) |
I think some syntactic sugar "openInNewTab" would be interesting in anchors.
The text was updated successfully, but these errors were encountered: