Merge pull request #1407 from SeasideSt/pharo12

Pharo12

.github/workflows/ci.yml

@@ -8,7 +8,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        smalltalk: [ Pharo64-11, Pharo64-10, Pharo64-9.0, Pharo64-8.0, Pharo64-7.0, GemStone64-3.7.0, GemStone64-3.6.6, GemStone64-3.5.7 ]
+        smalltalk: [ Pharo64-11, Pharo64-10, Pharo64-9.0, Pharo64-8.0, GemStone64-3.7.1, GemStone64-3.6.8, GemStone64-3.5.7 ]
         experimental: [ false ]
         include:
           - smalltalk: Pharo64-12
@@ -47,6 +47,7 @@ jobs:
           name: Screenshots Test Failures ${{ matrix.smalltalk }}
           path: ${{ env.SMALLTALK_CI_BUILD }}/*.png
       - name: Upload coverage to Codecov
-        uses: codecov/codecov-action@v3
+        uses: codecov/codecov-action@v4
         with:
           name: ${{ matrix.smalltalk }}
+          token: ${{ secrets.CODECOV_TOKEN }}

.smalltalk.ston

@@ -27,6 +27,10 @@ SmalltalkCISpec {
       #platforms : [ #gemstone ]
     }
   ],
+  #preTesting : SCICustomScript {
+    #path : 'scripts/preTestingPharo.st',
+    #platforms : [ #pharo ]
+  },
   #testing : {
       #defaultTimeout : 30,
       #exclude : {

repository/Seaside-Pharo110-Slime.package/WAChangesStateWhileRenderingRule.class/instance/afterCheck.mappings..st

@@ -1,7 +1,7 @@
 hooks
 afterCheck: aNode mappings: dict
 
-	aNode methodNode method isRenderingMethod ifFalse: [ ^ false ].
+	aNode methodNode compiledMethod isRenderingMethod ifFalse: [ ^ false ].
 	aNode isWrite ifFalse: [ ^ false ].
 	(WASlime isWithinCallback: aNode) ifTrue:[ ^ false ].
 

repository/Seaside-Pharo110-Slime.package/WADoNotUseWhileRenderingRule.class/instance/afterCheck.mappings..st

@@ -1,6 +1,6 @@
 hooks
 afterCheck: aNode mappings: dict
 
-	aNode methodNode method isRenderingMethod ifFalse: [ ^ false ].
+	aNode methodNode compiledMethod isRenderingMethod ifFalse: [ ^ false ].
 	(WASlime isWithinCallback: aNode) ifTrue: [ ^ false ].
 	^ true

repository/Seaside-Pharo110-Slime.package/WADoNotUseWithinCallbackRule.class/instance/afterCheck.mappings..st

@@ -1,6 +1,6 @@
 hooks
 afterCheck: aNode mappings: dict
 
-	aNode methodNode method isRenderingMethod ifFalse: [ ^ false ].
+	aNode methodNode compiledMethod isRenderingMethod ifFalse: [ ^ false ].
 	(WASlime isWithinCallback: aNode) ifFalse: [ ^ false ].
 	^ true

repository/Seaside-Pharo110-Slime.package/WAInstantiatesComponentWhileRenderingRule.class/instance/afterCheck.mappings..st

@@ -2,7 +2,7 @@ hooks
 afterCheck: aNode mappings: dict
 
 	| class |
-	aNode methodNode method isRenderingMethod ifFalse: [ ^ false ].
+	aNode methodNode compiledMethod isRenderingMethod ifFalse: [ ^ false ].
 	class := Smalltalk classNamed: aNode receiver name.
 	class ifNil: [ ^ false ].
 	^ class isBehavior and: [

repository/Seaside-Pharo110-Slime.package/WASequencedAsynchronousCallsRule.class/instance/afterCheck.mappings..st

@@ -2,7 +2,7 @@ hooks
 afterCheck: aNode mappings: dict
 
 	| owner |
-	aNode methodNode method isRenderingMethod ifFalse:[ ^ false ].
+	aNode methodNode compiledMethod isRenderingMethod ifFalse:[ ^ false ].
 	owner := aNode isCascaded
 		ifTrue: [ aNode parent parent ]
 		ifFalse: [ aNode parent ].

repository/Seaside-Pharo110-Slime.package/WAUnnecessaryBlockPassedToBrushRule.class/instance/afterCheck.mappings..st

@@ -1,7 +1,7 @@
 hooks
 afterCheck: aNode mappings: dict
 
-	aNode methodNode method isRenderingMethod ifFalse:[ ^ false ].
+	aNode methodNode compiledMethod isRenderingMethod ifFalse:[ ^ false ].
 	^ (aNode selector = #with:)
 		ifTrue: [ WASlime isBrushSelector: aNode receiver selector ] 
 		ifFalse: [ WASlime isBrushSelector: aNode selector ]

repository/Seaside-Pharo110-Slime.package/WAUnnecessaryWithSentToBrushRule.class/instance/afterCheck.mappings..st

@@ -1,7 +1,7 @@
 hooks
 afterCheck: aNode mappings: dict
 
-	aNode methodNode method isRenderingMethod ifFalse: [ ^ false ].
+	aNode methodNode compiledMethod isRenderingMethod ifFalse: [ ^ false ].
 	^ (aNode parent isCascade not)
 		and: [ (WASlime isBrushSelector: aNode receiver selector)
 		and: [ (WASlime isBrushSelector: aNode receiver selector , ':')

repository/Seaside-Pharo110-Slime.package/WAWithHasToBeLastMessageInCascadeRule.class/instance/afterCheck.mappings..st

@@ -1,7 +1,7 @@
 hooks
 afterCheck: aNode mappings: dict
 
-	^ aNode methodNode method isRenderingMethod and: [
+	^ aNode methodNode compiledMethod isRenderingMethod and: [
 		  aNode parent isCascade and: [
 			  aNode parent messages last ~= aNode and: [
 				  WASlime isBrushSelector: aNode receiver selector ] ] ]

repository/Seaside-Pharo110-Slime.package/monticello.meta/categories.st

@@ -1 +1 @@
-SystemOrganization addCategory: #'Seaside-Pharo110-Slime'!
+self packageOrganizer ensurePackage: #'Seaside-Pharo110-Slime' withTags: #()!

repository/Seaside-Tests-Pharo-Core.package/WAPharoFileLibraryTest.class/instance/testAddAllFilesIn.st

@@ -11,12 +11,11 @@ testAddAllFilesIn
 		(directory / '.Seaside_Store') ensureCreateFile .
 		(directory / 'foo') ensureCreateFile.
 		GRPlatform current doSilently: [
-			library := WAFileLibrary
-				subclass: #XXXTestFileLibrary
-				instanceVariableNames: ''
-				classVariableNames: ''
-				poolDictionaries: ''
-				category: 'Uncategorized'.
+			library := WAFileLibrary classInstaller make: [ :builder |
+				builder
+					superclass: WAFileLibrary;
+					name: #XXXTestFileLibrary;
+					environment: WAFileLibrary environment ].
 		[ library addAllFilesIn: directory fullName.
 			self assert: library selectors size = 1 ] "reject .Seaside_Store"
 				ensure: [ library removeFromSystem ] ] ]

repository/Seaside-Tests-Pharo-Core.package/monticello.meta/categories.st

@@ -1 +1 @@
-SystemOrganization addCategory: #'Seaside-Tests-Pharo-Core'!
+self packageOrganizer ensurePackage: #'Seaside-Tests-Pharo-Core' withTags: #()!

repository/Seaside-Tests-Pharo-Development.package/monticello.meta/categories.st

@@ -1 +1 @@
-SystemOrganization addCategory: #'Seaside-Tests-Pharo-Development'!
+self packageOrganizer ensurePackage: #'Seaside-Tests-Pharo-Development' withTags: #()!

repository/Seaside-Tests-Pharo-Email.package/GRPharoPlatformTest.extension/instance/testSeasideSmtpServer.st

@@ -1,8 +1,9 @@
 *seaside-tests-pharo-email
 testSeasideSmtpServer
 
-	| seasideSmtpServer |
-	seasideSmtpServer := [ GRPlatform current seasideSmtpServer  ]
-		on: ProvideAnswerNotification
-		do: [ :e | e resume: '1.2.3.4' ].
+	| seasideSmtpServer oldSmtpServer |
+	oldSmtpServer := [ MailComposition smtpServer ] on: Error do: [ :e | 	"If the smtpServer was not set, an error is thrown. Set it back to nil afterwards." nil ].
+	MailComposition setSmtpServer: '1.2.3.4'.
+	[ seasideSmtpServer := GRPlatform current seasideSmtpServer ] 
+		ensure: [ MailComposition setSmtpServer: oldSmtpServer ].
 	self assert: seasideSmtpServer isString

repository/Seaside-Tests-Pharo-Email.package/monticello.meta/categories.st

@@ -1 +1 @@
-SystemOrganization addCategory: #'Seaside-Tests-Pharo-Email'!
+self packageOrganizer ensurePackage: #'Seaside-Tests-Pharo-Email' withTags: #()!

repository/Seaside-Zinc-Core.package/ZnZincServerAdaptor.class/instance/convertMultipartStreamingEntity.with..st

@@ -9,9 +9,7 @@ convertMultipartStreamingEntity: anEntity with: aMultiValueDictionary
 		partsDecodeWith: [ :znMimePart |
 			aMultiValueDictionary
 				at: znMimePart fieldName
-				add: (self codec url decode: (znMimePart hasEntity
-					ifTrue: [ znMimePart fieldValueString ]
-					ifFalse: [ '' ])) ]
+				add: (self codec url decode: (znMimePart hasEntity ifTrue: [ znMimePart fieldValueString ] ifFalse: [ '' ])) ]
 		decodeFilesWith: [ :znMimePart :filePath |
 			"Empty file + empty filename means that the file form
 			field did not contain a value (no file was selected)."

repository/Seaside-Zinc-Core.package/monticello.meta/categories.st

@@ -1 +1 @@
-SystemOrganization addCategory: #'Seaside-Zinc-Core'!
+self packageOrganizer ensurePackage: #'Seaside-Zinc-Core' withTags: #()!

scripts/preTestingPharo.st

@@ -0,0 +1 @@
+Deprecation activateTransformations: false.