Allow GUI to only mount as a drive letter on Windows #450
Conversation
jfantinhardesty
requested review from
Dabnsky,
Ferelith-maker and
foodprocessor
as code owners
|
Can you push a screenshot of this in action into this PR's description so we can see it without having to build it? |
| self.button_driveLetter = QtWidgets.QPushButton('Drive Letter') | ||
| self.button_driveLetter.setToolTip('Select an unused drive letter for mounting') | ||
|
|
||
| self.horizontalLayout_3.addWidget(self.button_driveLetter) |
There was a problem hiding this comment.
I would recommend renaming the horizontalLayout to something that can help identify where the dev is in the code with reference to the UI. For example, lineEdit_mountPoint tells us specifically what we're using and for what. Is there a way we can reference horizontalLayout_3 to something we are familiar with?
There was a problem hiding this comment.
I realize now that a widget is being added after the UI has been compiled into a python file. Most of the elements have been added using the .ui source in QTCreator. What are you opinions in keeping to that convention, that way we don't have to rename horizontalLayout_3?
What type of Pull Request is this? (check all applicable)
Describe your changes in brief
This changes the GUI to only allow mounting as a drive letter on Windows, to reduce user confusion and simplify the Windows mounting process. It replaces the browse button with one for drive letters that display the available drive letters to mount on. The old code is still there, so you can manually type a path and still mount to it, but the browse button in gone.
Checklist
Related Issues