String parameter should take generic Into<String>

[billy1624]

PR Info

• Dependents:
  • Replace string types implementations with Into<String> sea-orm#1439

Breaking Changes

• Changed the &str parameter of the following methods to a generic T: Into<String>: Expr::cust():

  • Expr::cust_with_values()
  • Expr::cust_with_expr()
  • Expr::cust_with_exprs()
  • TableForeignKey::name()
  • ForeignKeyCreateStatement::name()
  • ForeignKeyDropStatement::name()
  • TableIndex::name()
  • IndexCreateStatement::name()
  • IndexDropStatement::name()
  • SqlWriterValues::new()
  • ColumnType::custom()
  • TableCreateStatement::engine()
  • TableCreateStatement::collate()
  • TableCreateStatement::character_set()
  • TableRef::new()
  • LikeExpr::str()

• Changed the String parameter of the following methods to a generic ColumnType::extra():

  • LikeExpr::new()

Changes

• Provide blanket IntoLikeExpr implementations for all types implemented Into<String>

Deprecates

• Deprecated LikeExpr::str(), please use LikeExpr::new() instead

[ikrivosheev]

@billy1624 hello! I have pushed new commit.

[billy1624]

Hey @ikrivosheev, sorry for the delay. Had been starting a new proprietary project in the past two weeks loll. Now, I'm back :)

[ikrivosheev]

@billy1624 hello! LGTM!

[tyt2y3]

I think this has a real benefit - if given a String, we don't have to allocate a second time.

[billy1624]

I think this has a real benefit - if given a String, we don't have to allocate a second time.

Yes, we only .clone() / .to_owned() while necessary

[github-actions]

🎉 Released In 0.29.0 🎉

Your participation is what makes us unique; your adoption is what drives us forward.
Thank you all in the Rust community for making SeaQL what it is today. 🦀
You are also invited to shape it's future! Please star our repos, every ⭐ counts!

[github-actions]

🎉 Released In 0.29.1 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.