Support the use of chrono::DateTime<Utc> using the type alias DateTim… #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eUtc Add a test to ensure the DateTimeUtc is parsed and converted to SQL equivalent of TIMESTAMP
|
@billy1624 @tyt2y3 Any thoughts on this are welcome |
billy1624
reviewed
Jan 6, 2022
billy1624
reviewed
Jan 6, 2022
|
Btw... we have to update |
Move FixedOffset to its own `From` implementation Implement test for Utc
|
@billy1624 I have moved the |
billy1624
reviewed
Jan 7, 2022
src/value.rs
Outdated
Comment on lines
597
to
603
| #[cfg(feature = "with-chrono")] | ||
| pub fn as_ref_date_time_utc(&self) -> Option<String> { | ||
| match self { | ||
| Self::DateTimeUtc(v) => v.as_ref().map(|v| v.naive_utc().to_string()), | ||
| _ => panic!("not Value::DateTimeUtc"), | ||
| } | ||
| } |
There was a problem hiding this comment.
Here should return Option<&DateTime<Utc>> instead of serializing it as string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support DateTime natively.
After researching and diving into the code, I found that the best way is to convert the
DateTime<Utc>into aDateTime<FixedOffset>with theFixedOffsetbeing based onchrono::Utc. This is helpful especially in databases like MySQL which store theTIMESTAMPin UTC despite a timezone being specified.