Check to make sure migration name is valid #879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AngelOnFira welcome back! |
billy1624
reviewed
Jul 25, 2022
Comment on lines
+256
to
+262
| // Make sure the migration name doesn't contain any characters that | ||
| // are invalid module names in Rust. | ||
| if migration_name.contains('-') { | ||
| return Err(Box::new(MigrationCommandError::InvalidName( | ||
| "Invalid character used in migration name".to_string(), | ||
| ))); | ||
| } |
There was a problem hiding this comment.
Hey @AngelOnFira, sorry for the delay. I think the error message can be more specific? E.g. hyphen - cannot be used in migration name
There was a problem hiding this comment.
Such as...
Suggested change
| // Make sure the migration name doesn't contain any characters that | |
| // are invalid module names in Rust. | |
| if migration_name.contains('-') { | |
| return Err(Box::new(MigrationCommandError::InvalidName( | |
| "Invalid character used in migration name".to_string(), | |
| ))); | |
| } | |
| // Make sure the migration name doesn't contain any characters that | |
| // are invalid module names in Rust. | |
| if migration_name.contains('-') { | |
| return Err(Box::new(MigrationCommandError::InvalidName( | |
| "Hyphen `-` cannot be used in migration name".to_string(), | |
| ))); | |
| } |
billy1624
reviewed
Jul 25, 2022
billy1624
changed the base branch from
master
to
catch-invalid-migration-name
billy1624
changed the base branch from
catch-invalid-migration-name
to
master
billy1624
reviewed
Oct 26, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a migration named
initial-tables, however, I had to change it since it wasn't valid as a Rust module name.I'm sure there are some other characters that should be filtered out, but I didn't look too deep. Also, I created a custom error for this, but I'm not super sure if that's the cleanest place to put it. I can make any changes necessary :)