-
-
Notifications
You must be signed in to change notification settings - Fork 512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replaced usize with u64 in PaginatorTrait #789
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liberwang1013 thank you! LGTM!
Thank you for the contribution. Was there an issue/ context that why you think u64 is a better choice than usize? |
@tyt2y3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contributions! @liberwang1013
Hey @tyt2y3, the context: https://discord.com/channels/873880840487206962/900758376164757555/983627886756003891 |
Let me think twice 🤔 |
@tyt2y3, I review PR: #768 (comment) and here we use: |
But on the other hand, |
Ah. Actually if we decided on that we can change all usize to u64, or the other way around. |
@tyt2y3, @billy1624 prepared PR for the update sqlx, I think that changing the type is not such a terrible change. |
b3593f9
to
f637c7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you all for your input |
PR Info
this pr replaced
usize
withu64
in paginated query.Changes
usize
withu64
in traitPaginatorTrait
usize
withu64
in structPaginator