Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use file!() macro to avoid manually defining the name of migration #736

Merged
merged 5 commits into from
Jun 28, 2022
Merged

Use file!() macro to avoid manually defining the name of migration #736

merged 5 commits into from
Jun 28, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented May 16, 2022 •
edited
Loading

PR Info

Adds

  • DeriveMigrationName procedural macro
  • get_file_stem helper method to parse and get file stem

Changes

  • Update all migrations to use the new DeriveMigrationName procedural macro

@billy1624 billy1624 self-assigned this May 16, 2022
ikrivosheev
ikrivosheev approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@ikrivosheev ikrivosheev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@billy1624 billy1624 requested a review from tyt2y3 May 16, 2022 10:41
@billy1624 billy1624 marked this pull request as ready for review May 16, 2022 10:41
@tyt2y3
Copy link
Member

tyt2y3 commented Jun 28, 2022

Awesome

@tyt2y3 tyt2y3 merged commit 1054d64 into master Jun 28, 2022
@tyt2y3 tyt2y3 deleted the derive-migration-name branch June 28, 2022 16:43
@billy1624 billy1624 mentioned this pull request Jul 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikrivosheev ikrivosheev ikrivosheev approved these changes

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use file! in migration files
3 participants
@billy1624 @tyt2y3 @ikrivosheev