Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added delete_by_id #590

Merged
merged 5 commits into from
Mar 21, 2022
Merged

Added delete_by_id #590

merged 5 commits into from
Mar 21, 2022

Conversation

ShouvikGhosh2048
Copy link
Contributor

PR Info

Adds

Adds a function delete_by_id to delete by primary key.

Fixes

None

Breaking Changes

None

Changes

Added delete_by_id + a unit test.

tests/delete_by_id_tests.rs Outdated Show resolved Hide resolved
tests/delete_by_id_tests.rs Show resolved Hide resolved
@AbhijithGanesh
Copy link

LGTM👍

Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ShouvikGhosh2048, thanks for contributing! This looks good!

@billy1624 billy1624 requested a review from tyt2y3 March 14, 2022 09:18
@tyt2y3 tyt2y3 merged commit 12f6661 into SeaQL:master Mar 21, 2022
billy1624 added a commit to SeaQL/seaql.github.io that referenced this pull request Mar 25, 2022
@ShouvikGhosh2048 ShouvikGhosh2048 deleted the add-delete-by-id branch June 7, 2022 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Update / Delete by id
4 participants