Describe default value of ActiveValue on document #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billy1624
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
Hey @Ken-Miura, thanks for the contributions and making SeaORM docs better!
Do let us know if you find any other part in the source code that is worth improving :)
This was referenced Apr 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Show what default value of ActiveValue is.
It looks like Default value of ActiveValue is used frequently on document (for example https://docs.rs/sea-orm/latest/sea_orm/entity/trait.ActiveModelTrait.html#example-postgres). But the default value is not clearly described in document. So I added that.
I think it is better to describe default value of the type in document. Standard library also describes that (for example https://doc.rust-lang.org/src/alloc/string.rs.html#2128)