Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support DateTime<Utc> & DateTime<Local> #489

Merged
merged 3 commits into from
Feb 1, 2022
Merged

Support DateTime<Utc> & DateTime<Local> #489

merged 3 commits into from
Feb 1, 2022

Conversation

billy1624
Copy link
Member

@billy1624 billy1624 commented Jan 26, 2022 •
edited
Loading

PR Info

Added

  • supports saving & querying DateTimeUtc
  • supports saving & querying DateTimeLocal
  • set default value of ColumnDef
  • set default value of each column when generating create table statement with Schema::create_table_from_entity method

@billy1624 billy1624 self-assigned this Jan 26, 2022
@billy1624 billy1624 mentioned this pull request Jan 26, 2022
Merged
@billy1624 billy1624 force-pushed the date-time-utc-local branch 2 times, most recently from c470523 to 666b05c Compare January 26, 2022 10:30
@billy1624 billy1624 marked this pull request as ready for review January 26, 2022 11:45
@billy1624 billy1624 requested a review from tyt2y3 January 26, 2022 11:45
@tyt2y3
Copy link
Member

tyt2y3 commented Jan 27, 2022

Seems Charles's code is included. Does that mean we can close 429?

@billy1624
Copy link
Member Author

Seems Charles's code is included. Does that mean we can close 429?

Correct!

billy1624 added a commit to SeaQL/seaql.github.io that referenced this pull request Jan 31, 2022
@billy1624
Support DateTimeUtc & DateTimeLocal (SeaQL/sea-orm#489)
f8e723b
charleschege and others added 3 commits February 1, 2022 14:27
@charleschege @tyt2y3
Support the use of chrono::DateTime<Utc> in sea-orm
52f38a1 
Add documentation for this

Temporarily use a fork to include new Sea-query code

Add tests for DateTimeUtc

Solve Github actions error by add the code to create a table

Assertion accuracy tests

Rectify incorrect format
@billy1624 @tyt2y3
Refactoring
8145088 
`ColumnDef` with default value

Cargo fmt

Update docs

Fixup

Support `DateTimeLocal`

Update docs

Codegen write db timestamp column as `DateTimeUtc` type

Update dependency

Merge branch 'sea-query/add-new-column-ref' into pr/429

feat: apply alias on `ColumnRef::SchemaTableColumn`
@tyt2y3
Update sea-query dependency
7f3ad2e
@tyt2y3 tyt2y3 merged commit e63d463 into master Feb 1, 2022
@tyt2y3 tyt2y3 deleted the date-time-utc-local branch February 1, 2022 07:25
billy1624 added a commit to SeaQL/seaql.github.io that referenced this pull request Feb 4, 2022
@billy1624
ColumnDef with default value (SeaQL/sea-orm#489)
b3cd22d
This was referenced Apr 25, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 Awaiting requested review from tyt2y3

Assignees

@billy1624 billy1624

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support DateTime<Utc> & DateTime<Local>
3 participants
@billy1624 @tyt2y3 @charleschege