Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the argument entity.table_ref() instead of just entity. #318

Merged
merged 8 commits into from Nov 17, 2021
Merged

Pass the argument entity.table_ref() instead of just entity. #318

merged 8 commits into from Nov 17, 2021

Conversation

ghost
Copy link

@ghost ghost commented Nov 15, 2021

Pass the reference instead of the entity itself.

@billy1624
Copy link
Member

Hey @Josh-codes, I have added some commits, please check

@ghost
Copy link
Author

ghost commented Nov 16, 2021

Will test (:

@billy1624 billy1624 mentioned this pull request Nov 17, 2021
10 tasks
Cargo.toml Outdated Show resolved Hide resolved
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! @Josh-codes

@tyt2y3 tyt2y3 merged commit 52bd28b into SeaQL:master Nov 17, 2021
@ghost
Copy link
Author

ghost commented Nov 17, 2021

@tyt2y3 why was this merged? it is using the beta 2021 version of rust version and had an outdated version string. 0.3.2

@tyt2y3
Copy link
Member

tyt2y3 commented Nov 17, 2021

@tyt2y3 why was this merged? it is using the beta 2021 version of rust version and had an outdated version string. 0.3.2

I don't get it. Is it specific to this PR?

@billy1624
Copy link
Member

I'm confused

@tyt2y3
Copy link
Member

tyt2y3 commented Nov 17, 2021

The final patch does not touch the Cargo.toml

@billy1624
Copy link
Member

@tyt2y3 why was this merged? it is using the beta 2021 version of rust version and had an outdated version string. 0.3.2

I think you undo the changes already

@ghost
Copy link
Author

ghost commented Nov 17, 2021

<img width="393" alt="Screenshot 2021-11-17 at 20 45 49" src="https://user-images.githubusercontent.com/43808099/142203217-165bf35b-34db-4c7d-9d2b-7cc3060eb4ed.png"
Screenshot 2021-11-17 at 20 46 38

also, if it doesn't get compile with those settings, shouldn't we just use the correct settings?

@ghost
Copy link
Author

ghost commented Nov 17, 2021

@tyt2y3 why was this merged? it is using the beta 2021 version of rust version and had an outdated version string. 0.3.2

I think you undo the changes already

I did, but I wanted to ask first.

@billy1624
Copy link
Member

Ahhhh I got what you mean

@billy1624
Copy link
Member

You mean why is this still 0.3.1. Correct?

sea-orm/Cargo.toml

Lines 4 to 14 in 0deeddd

[package]
name = "sea-orm"
version = "0.3.1"
authors = ["Chris Tsang <tyt2y7@gmail.com>"]
edition = "2021"
description = "🐚 An async & dynamic ORM for Rust"
license = "MIT OR Apache-2.0"
documentation = "https://docs.rs/sea-orm"
repository = "https://github.com/SeaQL/sea-orm"
categories = ["database"]
keywords = ["async", "orm", "mysql", "postgres", "sqlite"]

@billy1624
Copy link
Member

No worries, we will soon be releasing 0.4.0

@ghost
Copy link
Author

ghost commented Nov 17, 2021

No worries, we will soon be releasing 0.4.0

Yes, and also, why is it version 2021, that's a beta version of rust.

@billy1624
Copy link
Member

billy1624 commented Nov 17, 2021

No worries, we will soon be releasing 0.4.0

Yes, and also, why is it version 2021, that's a beta version of rust.

I think Rust Edition 2021 is stable now (since 1.56.0).
https://blog.rust-lang.org/2021/10/21/Rust-1.56.0.html#whats-in-1560-stable

@billy1624 billy1624 mentioned this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants