Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapter postgres url scheme #202

Merged
merged 7 commits into from
Sep 27, 2021
Merged

Adapter postgres url scheme #202

merged 7 commits into from
Sep 27, 2021

Conversation

baoyachi
Copy link
Contributor

@baoyachi baoyachi commented Sep 27, 2021

working for #200

  • adapter postgres url scheme
  • add new method in DbBackend with name url_starts_with.

* adapter postgrel url scheme
* refactor DbScheme
src/database/mod.rs Outdated Show resolved Hide resolved
@tyt2y3
Copy link
Member

tyt2y3 commented Sep 27, 2021

Thank you so much for this. I think my only nitpick would be to think of a better name for the method url_starts_with.
Because in left to right order, url starts with mysql makes sense.
But in reverse, mysql starts with url does not.
May be, I suggest, to use is_prefix_of as in mysql is prefix of url.
Sounds good?

@baoyachi
Copy link
Contributor Author

Thank you so much for this. I think my only nitpick would be to think of a better name for the method url_starts_with.
Because in left to right order, url starts with mysql makes sense.
But in reverse, mysql starts with url does not.
May be, I suggest, to use is_prefix_of as in mysql is prefix of url.
Sounds good?

Done.

Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@tyt2y3 tyt2y3 merged commit c12e0cd into SeaQL:master Sep 27, 2021
@baoyachi baoyachi deleted the adapter_url_scheme branch October 2, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres URI scheme designator can be be either postgresql:// or postgres://
3 participants