Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composite key cursor pagination #1216

Merged
merged 2 commits into from
Nov 14, 2022
Merged

Composite key cursor pagination #1216

merged 2 commits into from
Nov 14, 2022

Conversation

tyt2y3
Copy link
Member

@tyt2y3 tyt2y3 commented Nov 10, 2022

Fixes #1209

billy1624
billy1624 reviewed Nov 10, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting! We should extend this logic to Identity::Ternary as well

@tyt2y3
Copy link
Member Author

tyt2y3 commented Nov 10, 2022

@jacob-pro this might be all it takes?

@tyt2y3
Copy link
Member Author

tyt2y3 commented Nov 10, 2022

worthy to backport to 0.10 as well

@tyt2y3
Copy link
Member Author

tyt2y3 commented Nov 11, 2022

Would appreciate some input

@billy1624
Copy link
Member

Any thoughts? @jacob-pro @Sytten

billy1624
billy1624 reviewed Nov 11, 2022
View reviewed changes
Copy link
Member

@billy1624 billy1624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacob-pro
Copy link

I don't fully understand how the code works (I'm new to this library) - but the generated SQL looks correct!.
Thank you for fixing this!

@tyt2y3 tyt2y3 merged commit d082340 into master Nov 14, 2022
@tyt2y3 tyt2y3 deleted the paginate-1 branch November 14, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billy1624 billy1624 billy1624 left review comments

Assignees

@tyt2y3 tyt2y3

Labels
None yet
Projects
SeaQL Dev Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Composite key cursor pagination is broken
3 participants
@tyt2y3 @billy1624 @jacob-pro